feat: dependent resource inherits namespaces from controller config #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

csviri merged 2 commits into next from inherit-namespace-by-default

Mar 11, 2022

Collaborator

csviri commented Mar 10, 2022 •

edited

Loading

The primary objective was to inherit the default namespace to the dependent informers if not configured explicitly (standalone).
For the we need the ControllerConfiguration not ConfigurationService ( but that is accessible from controller config). So unified also the contexts to provide the controller configuration instead of configuration service. (This part is optional)


          feat: dependent resource inherints namespaces from controller config

603cd76

csviri self-assigned this


          fix: Using ControllerConfiguration in context instead of ConfigService

1cbd063

sonarqubecloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
58 Code Smells

36.7% Coverage
0.0% Duplication

csviri requested a review from metacosm

March 10, 2022 15:21

metacosm approved these changes

View reviewed changes

Collaborator

metacosm left a comment

I'm OK with the change but that is a breaking change that will impact users (they will have to change their reconciler implementations).

csviri merged commit cfccc71 into next

csviri deleted the inherit-namespace-by-default branch

March 11, 2022 08:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet