Skip to content

fix: remove CRD check #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: remove CRD check #1056

wants to merge 1 commit into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 21, 2022

No description provided.

@csviri csviri requested review from metacosm and lburgazzoli March 21, 2022 13:51
@csviri csviri self-assigned this Mar 21, 2022
@csviri csviri removed the request for review from lburgazzoli March 21, 2022 13:51
@csviri csviri linked an issue Mar 21, 2022 that may be closed by this pull request
Remove CRD Checking on Start of the Operator #1054
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 64 Code Smells

39.9% 39.9% Coverage
0.3% 0.3% Duplication

metacosm
metacosm reviewed Mar 21, 2022
View reviewed changes
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java
}

// Apply validations that are not handled by fabric8
CustomResourceUtils.assertCustomResource(resClass, crd);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this adds more validation than just checking if the CRD exists so this removes more than just this check.

Copy link
Collaborator Author

@csviri csviri Mar 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but without the CRD, this is something that we actually cannot check either, or?

Copy link
Collaborator Author

@csviri csviri Mar 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also fine to have this functionality, just target defatult feature switch to false. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe we should keep the feature after all, though I have to admit that if it's off by default, I'm not sure people will ever use it… 🤔
That said, it could be activated by default in the extensions for some context (e.g. Quarkus' dev mode).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KK will issue an another PR, with default false.

@csviri csviri closed this Mar 22, 2022
@csviri
Copy link
Collaborator Author

csviri commented Mar 22, 2022

closed in favor of: #1063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm left review comments

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CRD Checking on Start of the Operator
2 participants
@csviri @metacosm