fix: set default CRD check to false

[csviri]

Seting default to false, since the latest release changed the behavior (with the fix). So I would rather have it handled this way for now, and creating a small patch release. So there is no confusion if somebody upgrades.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[metacosm]

The problem is that the behavior was actually wrong in the core, which ended up behaving like the default was false but, as far as I'm aware at least, this behaved properly in both the Spring Boot starter and the Quarkus extension… so in this case, this would be a breaking change.

[csviri]

It would not be breaking I think, I mean we can still keep the default true on those extensions. It won't be breaking in the sense that this is less restrictive. Everything will work that worked until now. But in pure java is actually a breaking change, users already complained on our discord channel.

[csviri]

Will created an another PR where we just log that checking CRD, and how to turn it off. That is always useful.

[metacosm]

It would not be breaking I think, I mean we can still keep the default true on those extensions. It won't be breaking in the sense that this is less restrictive. Everything will work that worked until now. But in pure java is actually a breaking change, users already complained on our discord channel.

Yes but they're actually complaining that a bug was fixed because that was the intended behavior 😉

[csviri]

It would not be breaking I think, I mean we can still keep the default true on those extensions. It won't be breaking in the sense that this is less restrictive. Everything will work that worked until now. But in pure java is actually a breaking change, users already complained on our discord channel.

Yes but they're actually complaining that a bug was fixed because that was the intended behavior wink

Just users did not know that, nowhere documented, and just everybody used the default. So it can be quite annoying. But basically it also should not be default true IMHO. We should aim for production with defaults.

[metacosm]

It would not be breaking I think, I mean we can still keep the default true on those extensions. It won't be breaking in the sense that this is less restrictive. Everything will work that worked until now. But in pure java is actually a breaking change, users already complained on our discord channel.

Yes but they're actually complaining that a bug was fixed because that was the intended behavior wink

Just users did not know that, nowhere documented, and just everybody used the default. So it can be quite annoying. But basically it also should not be default true IMHO. We should aim for production with defaults.

You could make the same point about the default behavior of watching all namespaces, which is not realistic for many operators…

[csviri]

You could make the same point about the default behavior of watching all namespaces, which is not realistic for many operators…

I don't understand how it is related. Watch all namespaces is absolutely a valid use case, lots of operators are deployed that way. But don't think there is a use case when we should check CRD on prod during startup. That might be on a dev environment. But on prod it should be already well tested.