Skip to content

fix: ResourceId toString #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2022
Merged

fix: ResourceId toString #1072

merged 2 commits into from
Mar 23, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 23, 2022

No description provided.

@csviri csviri self-assigned this Mar 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csviri csviri changed the title fix: ResourceId to string fix: ResourceId toString Mar 23, 2022
@csviri csviri requested a review from metacosm March 23, 2022 14:34
@metacosm
Copy link
Collaborator

Good catch, should we rename this as well: https://github.com/java-operator-sdk/java-operator-sdk/blob/0506091f6304bbe0b854d45e304eefe1a99a748f/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ExecutionScope.java#L21

@csviri
Copy link
Collaborator Author

csviri commented Mar 23, 2022

Good catch, should we rename this as well:

https://github.com/java-operator-sdk/java-operator-sdk/blob/0506091f6304bbe0b854d45e304eefe1a99a748f/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ExecutionScope.java#L21

hehe nice, fixed!

@csviri csviri merged commit d4137a9 into main Mar 23, 2022
@csviri csviri deleted the fix-resource-id-to-string branch March 23, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm