Skip to content

fix: minor improvements on logging and tests related to temp cache #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ public Optional<R> get(ResourceID resourceID) {
log.debug("Resource found in temporal cache for Resource ID: {}", resourceID);
return resource;
} else {
log.debug("Resource not found in temporal cache reading it from informer cache," +
" for Resource ID: {}", resourceID);
return super.get(resourceID);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public synchronized void putUpdatedResource(T newResource, String previousResour
cache.put(resourceId, newResource);
} else {
// if something is in cache it's surely obsolete now
log.debug("Trying to remove an obsolete resource from cache for id: {}", resourceId);
cache.remove(resourceId);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class StandaloneDependentTestReconciler
KubernetesClientAware, ErrorStatusHandler<StandaloneDependentTestCustomResource> {

private KubernetesClient kubernetesClient;
private boolean errorOccurred = false;
private volatile boolean errorOccurred = false;

DeploymentDependentResource deploymentDependent;

Expand Down