fix: shut down operator when failing to start #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metacosm
commented
Apr 5, 2022
metacosm
commented
- fix: start timer as daemon to avoid prolonging the app's life
- fix: exit operator on exception when starting
|
Wondering if we could make an integration test for this. |
csviri
reviewed
Apr 7, 2022
| } else { | ||
| // extract matching information from URI in the message if available | ||
| final var message = exception.getMessage(); | ||
| final var regex = Pattern.compile(".*http(s?)://[^/]*/api(s?)/(\\S*).*").matcher(message); |
There was a problem hiding this comment.
We should do something about the related SONAR issue (maybe just no sonar?) or based on the instructions.
metacosm
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.