Skip to content

aggregate exception improvement #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csviri merged 4 commits into from
May 3, 2022
Merged

aggregate exception improvement #1188

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c8eba8
aggregate exception improvement
csviri May 2, 2022
01153b1
null check
csviri May 2, 2022
28d8381
fix: avoid NPE when creating AggregatedOperatorException
metacosm May 2, 2022
8751b6c
fix: format
metacosm May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ...framework-core/src/main/java/io/javaoperatorsdk/operator/AggregatedOperatorException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,30 @@
package io.javaoperatorsdk.operator;

import java.util.Arrays;
import java.util.Collections;
import java.util.List;

public class AggregatedOperatorException extends OperatorException {

private final List<Exception> causes;

public AggregatedOperatorException(String message, Exception... exceptions) {
super(message);
this.causes = exceptions != null ? Arrays.asList(exceptions) : Collections.emptyList();
super(message, exceptions[0]);
Copy link
Collaborator

@metacosm metacosm May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might NPE if no exception is passed.

Copy link
Collaborator Author

@csviri csviri May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed with null check

this.causes = Arrays.asList(exceptions);
}

public AggregatedOperatorException(String message, List<Exception> exceptions) {
super(message);
this.causes = exceptions != null ? exceptions : Collections.emptyList();
super(message, exceptions.get(0));
Copy link
Collaborator

@metacosm metacosm May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, we need to check that the given parameter is not null…

this.causes = exceptions;
}

public List<Exception> getAggregatedExceptions() {
return causes;
}

@Override
public String toString() {
return "AggregatedOperatorException{" +
"causes=" + causes +
'}';
}
}