-
Notifications
You must be signed in to change notification settings - Fork 220
feat: patch does not do optimistic locking #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5787eb0
to
f35c82e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
return new PostExecutionControl<>(false, null, false, null); | ||
} | ||
|
||
public static <R extends HasMetadata> PostExecutionControl<R> customResourceStatusPatched( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to have a builder for this since the combination of parameters is getting complex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's internal API, might be better yes. Maybe next time we can change this.
Hmm although, there are quite well defined these few cases. So this way it's also quite intentionally limiting.
Kudos, SonarCloud Quality Gate passed! |
In this PR we provide a locking status update and a non-locking status patch operation for update control