Skip to content

feat: patch does not do optimistic locking #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 17, 2022
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented May 11, 2022

In this PR we provide a locking status update and a non-locking status patch operation for update control

@csviri csviri self-assigned this May 11, 2022
csviri added 9 commits May 12, 2022 13:17
wip

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
@csviri csviri force-pushed the patch-no-optimistick-locking branch from 5787eb0 to f35c82e Compare May 12, 2022 11:18
@csviri csviri marked this pull request as ready for review May 12, 2022 11:27
@csviri csviri requested a review from metacosm May 12, 2022 11:33
@csviri csviri linked an issue May 12, 2022 that may be closed by this pull request
@csviri csviri linked an issue May 12, 2022 that may be closed by this pull request
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return new PostExecutionControl<>(false, null, false, null);
}

public static <R extends HasMetadata> PostExecutionControl<R> customResourceStatusPatched(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to have a builder for this since the combination of parameters is getting complex?

Copy link
Collaborator Author

@csviri csviri May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's internal API, might be better yes. Maybe next time we can change this.
Hmm although, there are quite well defined these few cases. So this way it's also quite intentionally limiting.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

73.7% 73.7% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit b981759 into main May 17, 2022
@csviri csviri deleted the patch-no-optimistick-locking branch May 17, 2022 07:42
@csviri csviri linked an issue May 17, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants