Skip to content

feat: parameterize http client implementation in ITs #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2023
Merged

feat: parameterize http client implementation in ITs #1839

merged 4 commits into from
Apr 5, 2023

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Mar 31, 2023 •
edited
Loading

Fixes #1801

@metacosm metacosm self-assigned this Mar 31, 2023
@metacosm metacosm requested a review from csviri March 31, 2023 14:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@metacosm metacosm marked this pull request as ready for review March 31, 2023 18:58
csviri
csviri approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit 756cf67 into main Apr 5, 2023
@metacosm metacosm deleted the http-client-test-matrix branch April 5, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run integration tests on all Fabric8 HTTP client implementations
2 participants
@metacosm @csviri