feat: create a junit5 extension #507
Conversation
lburgazzoli
force-pushed
the
junit-ext
branch
4 times, most recently
from
b60afb3 to
ef78ead
Compare
| @@ -253,13 +258,21 @@ private void throwMissingCRDException(String crdName, String specVersion, String | |||
| return false; | |||
| } | |||
|
|
|||
| private static class ControllerRef { | |||
| public static class ControllerRef { | |||
There was a problem hiding this comment.
I plan on making this class more widely used, cf #496
| public final ResourceController controller; | ||
| public final ControllerConfiguration configuration; | ||
|
|
||
| public ControllerRef(ResourceController controller, ControllerConfiguration configuration) { | ||
| this.controller = controller; | ||
| this.configuration = configuration; | ||
| } | ||
|
|
||
| public ResourceController getController() { |
There was a problem hiding this comment.
Why add getters if the instance variables are public final… Use one or the other :)
There was a problem hiding this comment.
I think this is a leftover when using the ResourceController as part of some stream operation so getter/setter where require for method references
Maybe we should discuss this issue, running integration/functional tests in parallel would boost the speed of the test. However there is a benefit to have tests isolated completely (the runs), it's already quite hard analyse and find the problem in those tests in case of failure. |
The tests are isolated as each test runs it its own namespace so there should not be any interference by many tests running in parallel. We can make the parallel run something we enable only in CI |
|
superseded by #545 |
@metacosm @csviri I had some spare time and I have started hacking a JUnit 5 extension to make it easy to run integration tests.
It is quire basic at the moment but my goal is:
Let me know if you think it is work to create such JUnit 5 extensions