Skip to content

Fixes v2 #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2021
Merged

Fixes v2 #639

merged 2 commits into from
Oct 29, 2021

Conversation

metacosm
Copy link
Collaborator

No description provided.

@metacosm
fix: replace jandex plugin by Quarkus detection of beans.xml files
9a1551f 
This allows to not run into compatibility between index versions.
@metacosm metacosm self-assigned this Oct 28, 2021
@snowdrop-bot snowdrop-bot mentioned this pull request Oct 28, 2021
Closed
@metacosm metacosm force-pushed the fixes-v2 branch 2 times, most recently from b46805c to b71b210 Compare October 29, 2021 07:49
csviri
csviri reviewed Oct 29, 2021
View reviewed changes
operator-framework-core/src/test/java/io/javaoperatorsdk/operator/ControllerManagerTest.java Outdated

public class ControllerManagerTest {

@Test(expected = OperatorException.class)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in v1, Junit 5 should be used.

csviri
csviri approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUnit version, otherwise LGTM

@metacosm
fix: improve duplicated controller detection, add tests
8ad359b 
While we originally planned to make it possible to register controllers
with the same CR but with different version (see #637), that behavior
should actually be forbidden since only one CR version can be served,
see #94 for more details.
@metacosm metacosm merged commit 22daa8a into v2 Oct 29, 2021
@metacosm metacosm deleted the fixes-v2 branch October 29, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metacosm @csviri