Add tomcat operator sample #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `spring-boot.version` from 2.5.5 to 2.5.6. Updates `spring-boot-dependencies` from 2.5.5 to 2.5.6 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.5.5...v2.5.6) Updates `spring-boot-maven-plugin` from 2.5.5 to 2.5.6 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.5.5...v2.5.6) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-dependencies dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [awaitility](https://github.com/awaitility/awaitility) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/awaitility/awaitility/releases) - [Changelog](https://github.com/awaitility/awaitility/blob/master/changelog.txt) - [Commits](awaitility/awaitility@awaitility-4.1.0...awaitility-4.1.1) --- updated-dependencies: - dependency-name: org.awaitility:awaitility dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Properly start event handler when starting the event source. Minor clean-ups. Fixes #630 Co-authored-by: csviri <[email protected]>
|
@adam-sandor @metacosm moved the sample to use informers, also some minor changes to make it easy to write. (those are already in v2, or in different way) Also renamed the |
csviri
approved these changes
Nov 8, 2021
This was referenced Nov 8, 2021
This was referenced Nov 10, 2021
adam-sandor
commented
Nov 11, 2021
adam-sandor
commented
Nov 11, 2021
...ators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappController.java
Show resolved
Hide resolved
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
We can delete I don't mind
metacosm
approved these changes
Nov 12, 2021
|
I think we can still make improvements but let's get this merged first and address any remaining issue / improvements in subsequent PRs. |
|
🎉 |
csviri
added a commit
that referenced
this pull request
Nov 15, 2021
Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 15, 2021
Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 15, 2021
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 16, 2021
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 22, 2021
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
metacosm
added a commit
that referenced
this pull request
Nov 26, 2021
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Tomcat Operator sample from the samples repo and add end to end tests in the process.