fix: cover informer automatic start case

[csviri]

No description provided.

[lburgazzoli]

I think this need some sort of protection as there may be a race conditions between the event being fired and the eventHandler being set in the AbstractEventSource

[csviri]

Normally it is LifecycleAware , and we "run" the informer only on start. But there are some cases where the informer is run automtically when created in fabric8 client "Informable" way, (what we want, like it is passed as a param). Will address this in an issue for fabric8 client.

For now this is an ugly workaround :/

[lburgazzoli]

Yes but my understanding is that propagateEvent may run as per the invocation of the constructor so while the propagateEvent in invoked by an informer thread another thread my set the eventHandler.

Since the eventHandler is neither volatile nor protected by a lock then the two thread my see a different value for eventHandler, right ? Also, since there is a list of events, some events may get propagated and some other not.

[csviri]

ahh, good point, changed it to volatile.

But I don't understand the second point:

Also, since there is a list of events, some events may get propagated and some other not.

All the events are propagated from a list from one thread, so it's either sees the variable set or not, or?
Or the thread can see the actual reference from certain point of time...? This is what you mean?

[lburgazzoli]

assuming that esourceToUIDs.apply(object) produces 3 elements, and the eventHandler is set once the uids.forEach is processing the 2nd element, then the 3rd UID will trigger a reconcile, the first two don't.

It may be ok but I don't know.

[csviri]

The thing is with volatile (now set, thx) and LifecycleAware all should be covered, if the Informer is created and did not run. Now it can happen that if created in a certain way Informer.run method called automatically in fabric8 - will address this in fabric8 client and a subsequent issue here.

For now this workaround should mitigate this issues, there can be missed events on startup, but since this is event source and not a the main custom resource event source, it's not that big deal IMHO. Hopefully we can address this before we release v2. But actually will be just a docs from our side to not create an Informer event source when set as paramter. (Or check if the passed event source is running, in case yes log a warning)

[csviri]

Ok it's doable this way:
7eb3aa7

Added warn log message if user passes a running informer.