Skip to content

feature: ResourceID from first owner reference #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 17, 2022

No description provided.

@csviri csviri self-assigned this Jan 17, 2022
@@ -13,6 +13,15 @@ public static ResourceID fromResource(HasMetadata resource) {
resource.getMetadata().getNamespace());
}

public static Optional<ResourceID> fromFirstOwnerReference(HasMetadata dependentResource) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better if you'd use the implementation from the dependent resources branch: https://github.com/java-operator-sdk/java-operator-sdk/pull/785/files#diff-5166f926d491fa8bc37664176eb65ecb8dc051b8db0e3d3771fb817a1fbd462dR70-R80 so that merging later will be easier.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, changed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@csviri csviri requested a review from metacosm January 17, 2022 16:41
@csviri csviri merged commit d3863e1 into main Jan 17, 2022
@csviri csviri deleted the resourceid-from-owner-reference branch January 17, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants