Skip to content

Disable Sonar check on forks #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

andreaTP
Copy link
Collaborator

@andreaTP andreaTP commented Feb 1, 2022

This prevents the Sonar check to run on the forks (will be marked as "Skipped") instead of failing.

@andreaTP andreaTP marked this pull request as draft February 1, 2022 14:11
@andreaTP andreaTP force-pushed the disable-sonar-on-forks branch from 0d1463c to 4dddbb9 Compare February 1, 2022 14:33
@andreaTP andreaTP marked this pull request as ready for review February 1, 2022 14:33
@andreaTP
Copy link
Collaborator Author

andreaTP commented Feb 1, 2022

Closing and re-opening to trigger the CI again.

@andreaTP andreaTP closed this Feb 1, 2022
@andreaTP andreaTP reopened this Feb 1, 2022
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thx @andreaTP

@csviri
Copy link
Collaborator

csviri commented Feb 1, 2022

Just one question, why the owner is not checked on push?

@andreaTP
Copy link
Collaborator Author

andreaTP commented Feb 1, 2022

why the owner is not checked on push?

I assumed that:

  • we don't mind what ppl are doing on their own forks
  • push to main is already "restricted enough" in this repo

@csviri csviri merged commit 489e25d into operator-framework:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants