Skip to content

feat: executor service override #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.javaoperatorsdk.operator.api.config;

import java.util.Set;
import java.util.concurrent.ExecutorService;

import io.fabric8.kubernetes.api.model.HasMetadata;
import io.fabric8.kubernetes.client.Config;
Expand All @@ -16,6 +17,7 @@ public class ConfigurationServiceOverrider {
private Cloner cloner;
private int timeoutSeconds;
private boolean closeClientOnStop;
private ExecutorService executorService = null;

public ConfigurationServiceOverrider(
ConfigurationService original) {
Expand Down Expand Up @@ -65,6 +67,11 @@ public ConfigurationServiceOverrider withCloseClientOnStop(boolean close) {
return this;
}

public ConfigurationServiceOverrider withExecutorService(ExecutorService executorService) {
this.executorService = executorService;
return this;
}

public ConfigurationService build() {
return new ConfigurationService() {
@Override
Expand Down Expand Up @@ -120,6 +127,15 @@ public Metrics getMetrics() {
public boolean closeClientOnStop() {
return closeClientOnStop;
}

@Override
public ExecutorService getExecutorService() {
if (executorService != null) {
return executorService;
} else {
return ConfigurationService.super.getExecutorService();
}
}
};
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.javaoperatorsdk.operator.sample;

import java.util.concurrent.Executors;

import io.javaoperatorsdk.operator.Operator;
import io.javaoperatorsdk.operator.api.config.ConfigurationServiceOverrider;
import io.javaoperatorsdk.operator.config.runtime.DefaultConfigurationService;
Expand All @@ -8,9 +10,11 @@ public class PureJavaApplicationRunner {

public static void main(String[] args) {
Operator operator =
new Operator(ConfigurationServiceOverrider.override(DefaultConfigurationService.instance())
.withConcurrentReconciliationThreads(2)
.build());
new Operator(
ConfigurationServiceOverrider.override(DefaultConfigurationService.instance())
.withExecutorService(Executors.newCachedThreadPool())
.withConcurrentReconciliationThreads(2)
.build());
operator.register(new CustomServiceReconciler());
operator.start();
}
Expand Down