feat: Dependent Resources for External Resources #991
Conversation
# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/polling/PollingEventSource.java
# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/AbstractDependentResource.java # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/Updater.java # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
...amework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/Deleter.java
Outdated
Show resolved
Hide resolved
...ain/java/io/javaoperatorsdk/operator/api/reconciler/dependent/AbstractDependentResource.java
Outdated
Show resolved
Hide resolved
...ain/java/io/javaoperatorsdk/operator/api/reconciler/dependent/AbstractDependentResource.java
Outdated
Show resolved
Hide resolved
...amework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/Creator.java
Show resolved
Hide resolved
| } | ||
| return created; | ||
| } catch (RuntimeException e) { | ||
| if (isEventSourceARecentOperationEventFilter()) { |
There was a problem hiding this comment.
Shouldn't the cleanup happen all the time, not only in case of an exception?
There was a problem hiding this comment.
This is currently done by handleRecentCreateOrUpdate what can be confusing I agree, will check and change it
There was a problem hiding this comment.
Checked this, the problem is that it needs to be in the same synchonized block as it is now. Will check once more, but in a separate PR, would rather stick with this now. (when changed the tests started to fail)
There was a problem hiding this comment.
Can you create an issue to track this, please? Let's merge this!
...amework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/Updater.java
Show resolved
Hide resolved
...javaoperatorsdk/operator/processing/dependent/external/AbstractCachingDependentResource.java
Outdated
Show resolved
Hide resolved
.../javaoperatorsdk/operator/processing/dependent/external/AbstractSimpleDependentResource.java
Outdated
Show resolved
Hide resolved
|
|
||
| import static io.javaoperatorsdk.operator.processing.dependent.external.PollingDependentResource.DEFAULT_POLLING_PERIOD; | ||
|
|
||
| public abstract class PerResourcePollingDependentResource<R, P extends HasMetadata> |
There was a problem hiding this comment.
I have to admit that I'm still confused between this class and PollingDependentResource. Not sure what the differences are and when you'd use one or the other.
There was a problem hiding this comment.
The PerResource polls the supplier for every resource separatelly, the Poller just periodically polls an api regardless of the resources in the caches of the ControllerResourceEventSource
.../javaoperatorsdk/operator/processing/event/source/polling/PerResourcePollingEventSource.java
Outdated
Show resolved
Hide resolved
|
I made small changes that I think improve readability a little. If we can sort out the supply thing, the return values either not being used or returning |
|
Kudos, SonarCloud Quality Gate passed! |
WIP