Skip to content

Fix retry_enabled=False config flag to correctly disable SDK retry logic #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

asqui
Copy link

@asqui asqui commented Nov 6, 2019

This is needed because the retry logic in SDK doesn't work properly :-(
(see #21)

This is needed because the retry logic in SDK doesn't work properly :-(
(see opsgenie#21)
@mhamzak008
Copy link
Contributor

Thanks for the PR. Doing this does disable the retries, but then it doesn't retry at all, not even when it's enabled.
We have fixed the problem by implementing a custom callback function in #29

@asqui
Copy link
Author

asqui commented Nov 6, 2019

Hmm, that's surprising. I thought tested this and saw it correctly constructing a binary-tree of retry_any and retry_all objects.

If you think there's a bug in tenacity, it's worth submitting a bug report and/or PR at https://github.com/jd/tenacity -- I submitted a PR to this project last week and it got approved, merged, tested, and a new version released to PyPI inside of 90 minutes!

Closing this issue since it looks like you've worked around this another way.

@asqui asqui closed this Nov 6, 2019
@asqui asqui deleted the fix-retry_enabled branch November 6, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants