-
Notifications
You must be signed in to change notification settings - Fork 25
fix(iam-compartment): remove duplicate required_providers #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iam-compartment): remove duplicate required_providers #31
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
Hi @maxbrunet Thanks for the pull request. Before we can merge your code, can you please sign the contributor agreement (see above)? Also, The Terraform OCI provider's namespace has changed. Please update the oci provider definition to match https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/main/versions.tf |
Hi @hyder
I have signed it, it says "under review".
Yes, this removes the old one, the right definition has already been added here:
|
Lgtm. We'll merge once the oca is approved. Thanks again for your contribution. |
@hyder The OCA has been approved :) |
@hyder could you pls approve this one |
any news on this PR ? the module can't be used :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Follow up to #30, this one was missed:
Fixes #33