Skip to content

fix(iam-compartment): remove duplicate required_providers #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

maxbrunet
Copy link
Contributor

@maxbrunet maxbrunet commented Dec 5, 2022

Follow up to #30, this one was missed:

│ Error: Duplicate required providers configuration
│
│   on .terraform/modules/iam_compartment/modules/iam-compartment/versions.tf line 2, in terraform:
│    2:   required_providers {
│
│ A module may have only one required providers configuration. The required providers were previously configured at .terraform/modules/iam_compartment/modules/iam-compartment/main.tf:5,3-21.

Fixes #33

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Dec 5, 2022
@hyder
Copy link

hyder commented Dec 5, 2022

Hi @maxbrunet

Thanks for the pull request. Before we can merge your code, can you please sign the contributor agreement (see above)?

Also, The Terraform OCI provider's namespace has changed. Please update the oci provider definition to match https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/main/versions.tf

@maxbrunet
Copy link
Contributor Author

Hi @hyder

Before we can merge your code, can you please sign the contributor agreement (see above)?

I have signed it, it says "under review".

Also, The Terraform OCI provider's namespace has changed. Please update the oci provider definition to match oracle-terraform-modules/terraform-oci-oke@main/versions.tf

Yes, this removes the old one, the right definition has already been added here:

@hyder
Copy link

hyder commented Dec 5, 2022

Lgtm. We'll merge once the oca is approved.

Thanks again for your contribution.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Dec 8, 2022
@maxbrunet
Copy link
Contributor Author

@hyder The OCA has been approved :)

@karthicgit
Copy link
Member

@hyder could you pls approve this one

@nlamirault
Copy link

any news on this PR ? the module can't be used :(

Copy link

@hyder hyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@hyder hyder merged commit d1f0168 into oracle-terraform-modules:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Duplicate required providers configuration both on (versions.tf and main.tf) . A module may have only one required providers configuration
4 participants