56 oracle db integration #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingestion & retrieval with content rerefence only in vectorstore to the original text content in a field table
one shot vector store ingestion from a SQL query
oracle-contributor-agreement
bot
added
the
OCA Verified
cjbj
reviewed
Sep 30, 2025
gotsysdba
approved these changes
Oct 1, 2025
cjbj
reviewed
Oct 1, 2025
| with connection.cursor() as cursor: | ||
|
|
||
| cursor.execute(query) | ||
| rows = cursor.fetchmany(3) |
There was a problem hiding this comment.
I see you changed 2 to 3. My previous suggestion was actually to add cursor.prefetchrows = 3 - see the driver tuning doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation to ingest and embed texts from a column in a remote Oracle DB table.
It accepts VARCHAR field only.