-
Notifications
You must be signed in to change notification settings - Fork 781
Feature/ctags opts #2963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ctags opts #2963
Conversation
ebb2af1
to
f68b79e
Compare
Rebased to fix |
Also, use "powershell" not "Posh" for OpenGrok customizations, to match the built-in ctags language name as is done for e.g. "clojure" and "pascal" and their OpenGrok-overriden handling.
f68b79e
to
6de4f5a
Compare
Pushed a fix (with test) where a primary |
lgtm, merging, thank you @idodeclare |
Thank you for reviewing, @tarzanek |
@idodeclare Chris, could you please look at https://travis-ci.org/oracle/opengrok/jobs/609448885 ? |
I got ctags induced failures across the board (builds in Travis). I tried backing out the last changesets from HEAD one by one down to fb53154 and they all fail in the same mode with stuff like:
so it seems something changed in Univ ctags upstream. |
I’m restoring my MacBook after a logic board replacement. Hopefully I’ll be up and running before too long. Alas the large OpenGrok CI logs are not readable on my phone. |
The Lucene 8.3 Travis build had macOS job failure due to exceeded time. I restarted the job. The last macOS build (609448885) failed due to the ctags issue I described above. |
The restarted Lucene 8.3 macOS Travis job in the end failed with the same ctags problem as above. Univ ctags at cset 89393951. The Linux Travis builds at the time the Lucene 8.3 PR was built had Univ ctags at cset be621aec and they passed. |
Seems like Univ ctags cset 9fcdb06503d82f76aebdb84de9448642a0f2d54b seems to be working fine (still waiting on macOS builds but Linux builds are okay: https://travis-ci.org/vladak/OpenGrok/builds/610394792?utm_source=github_status&utm_medium=notification). Time for |
Known good Univ ctags csets:
It looks like one of the changes committed to Univ ctags over the weekend broke OpenGrok. |
Hello,
Please consider for integration this patch to support customizing
Ctags
language mapping (inclusion or exclusion) per-A,--indexer
so that Universal Ctags operation is changed too when users specify additional extensions or prefixes to map to analyzers (or unmap from them).Thank you.