Skip to content

Feature/ctags opts #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2019
Merged

Feature/ctags opts #2963

merged 3 commits into from
Nov 8, 2019

Conversation

idodeclare
Copy link
Contributor

Hello,

Please consider for integration this patch to support customizing Ctags language mapping (inclusion or exclusion) per -A,--indexer so that Universal Ctags operation is changed too when users specify additional extensions or prefixes to map to analyzers (or unmap from them).

Thank you.

@idodeclare
Copy link
Contributor Author

Rebased to fix Ctags conflict for .TS extension

@idodeclare
Add LangMap and tests
8904618
@idodeclare
Add getCtagsLang() method
973cf38 
Also, use "powershell" not "Posh" for
OpenGrok customizations, to match the built-in
ctags language name as is done for e.g. "clojure"
and "pascal" and their OpenGrok-overriden
handling.
@idodeclare
Use LangMap to customize Ctags from -A,--analyzer
6de4f5a
@idodeclare
Copy link
Contributor Author

idodeclare commented Oct 25, 2019 •
edited
Loading

Pushed a fix (with test) where a primary LangMap exclusion was not superseding a secondary inclusion.

@tarzanek
Copy link
Contributor

tarzanek commented Nov 8, 2019

lgtm, merging, thank you @idodeclare

@tarzanek tarzanek merged commit a2acfbd into oracle:master Nov 8, 2019
@idodeclare
Copy link
Contributor Author

Thank you for reviewing, @tarzanek

@idodeclare idodeclare deleted the feature/ctags_opts branch November 8, 2019 23:52
@tarzanek
Copy link
Contributor

@idodeclare Chris, could you please look at https://travis-ci.org/oracle/opengrok/jobs/609448885 ?
it seems the ctags tests fail on mac + jdk8
after applying this patch (bad auto merge?)

@vladak
Copy link
Member

vladak commented Nov 11, 2019 •
edited
Loading

I got ctags induced failures across the board (builds in Travis). I tried backing out the last changesets from HEAD one by one down to fb53154 and they all fail in the same mode with stuff like:

Nov 11, 2019 1:48:32 PM org.opengrok.indexer.analysis.Ctags doCtags
WARNING: execution exception
java.util.concurrent.ExecutionException: java.lang.InterruptedException: tagLine == null
	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.util.concurrent.FutureTask.get(FutureTask.java:206

so it seems something changed in Univ ctags upstream.

@idodeclare
Copy link
Contributor Author

I’m restoring my MacBook after a logic board replacement. Hopefully I’ll be up and running before too long.

Alas the large OpenGrok CI logs are not readable on my phone.

@vladak
Copy link
Member

vladak commented Nov 11, 2019 •
edited
Loading

The Lucene 8.3 Travis build had macOS job failure due to exceeded time. I restarted the job. The last macOS build (609448885) failed due to the ctags issue I described above.

@vladak
Copy link
Member

vladak commented Nov 11, 2019 •
edited
Loading

The restarted Lucene 8.3 macOS Travis job in the end failed with the same ctags problem as above. Univ ctags at cset 89393951. The Linux Travis builds at the time the Lucene 8.3 PR was built had Univ ctags at cset be621aec and they passed.

@vladak
Copy link
Member

vladak commented Nov 11, 2019 •
edited
Loading

Seems like Univ ctags cset 9fcdb06503d82f76aebdb84de9448642a0f2d54b seems to be working fine (still waiting on macOS builds but Linux builds are okay: https://travis-ci.org/vladak/OpenGrok/builds/610394792?utm_source=github_status&utm_medium=notification). Time for git bisect I guess.

@vladak
Copy link
Member

vladak commented Nov 11, 2019 •
edited
Loading

Known good Univ ctags csets:

  • be621aec
  • 9fcdb065

It looks like one of the changes committed to Univ ctags over the weekend broke OpenGrok.

@idodeclare idodeclare mentioned this pull request Nov 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idodeclare @tarzanek @vladak