Skip to content

Update Referrers API to match RC.1#191

Merged
shizhMSFT merged 8 commits into
oras-project:mainfrom
m5i-work:v2_api
Jun 27, 2022
Merged

Update Referrers API to match RC.1#191
shizhMSFT merged 8 commits into
oras-project:mainfrom
m5i-work:v2_api

Conversation

@m5i-work
Copy link
Copy Markdown
Contributor

@m5i-work m5i-work commented Jun 22, 2022 •
edited
Loading

Resolves #188

@m5i-work
Update referrers API
8028b2c 
Signed-off-by: Wei Meng <wemeng@microsoft.com>
@shizhMSFT shizhMSFT requested review from Wwwsylvia and shizhMSFT June 22, 2022 06:44
@m5i-work
minor fixes
7d442aa 
Signed-off-by: Wei Meng <wemeng@microsoft.com>
@Wwwsylvia
Copy link
Copy Markdown
Member

Wwwsylvia commented Jun 22, 2022

You may want the linked issue to be automatically closed once this PR is merged. See Linking a pull request to an issue using a keyword.

@m5i-work
Copy link
Copy Markdown
Contributor Author

m5i-work commented Jun 22, 2022

You may want the linked issue to be automatically closed once this PR is merged. See Linking a pull request to an issue using a keyword.

TIL!

Wwwsylvia
Wwwsylvia reviewed Jun 22, 2022
View reviewed changes
Comment thread registry/remote/url.go Outdated
Comment thread registry/remote/url.go Outdated
@m5i-work
Update function doc
8ed37c1 
Signed-off-by: Wei Meng <wemeng@microsoft.com>
@northtyphoon
Copy link
Copy Markdown

northtyphoon commented Jun 22, 2022

@m5i-work just want to make sure you are aware of, there is a change in rc1 spec regarding to pagination. The link url has been changes to relative url. https://github.com/oras-project/artifacts-spec/blob/v1.0.0-rc.1/manifest-referrers-api.md#paging-results
Not sure if existing code can handle both. You may consider to incorporate in current or future pr.

@m5i-work
Copy link
Copy Markdown
Contributor Author

m5i-work commented Jun 23, 2022 •
edited
Loading

just want to make sure you are aware of, there is a change in rc1 spec regarding to pagination. The link url has been changes to relative url. https://github.com/oras-project/artifacts-spec/blob/v1.0.0-rc.1/manifest-referrers-api.md#paging-results Not sure if existing code can handle both. You may consider to incorporate in current or future pr.

Thanks! The existing code already handles both.

Wwwsylvia
Wwwsylvia reviewed Jun 23, 2022
View reviewed changes
Comment thread registry/remote/url.go
shizhMSFT
shizhMSFT reviewed Jun 23, 2022
View reviewed changes
Comment thread registry/remote/url.go Outdated
@m5i-work
Use helper function
f51e2c6 
Signed-off-by: Wei Meng <wemeng@microsoft.com>
@shizhMSFT
Copy link
Copy Markdown
Contributor

shizhMSFT commented Jun 24, 2022

Note: Since this PR is for rc, let's merge it after #195

@m5i-work
Json field change
f6ca0dd 
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Wwwsylvia
Wwwsylvia reviewed Jun 24, 2022
View reviewed changes
Comment thread registry/remote/repository.go Outdated
Comment thread registry/remote/repository_test.go Outdated
m5i-work added 2 commits June 24, 2022 12:58
@m5i-work
Align var name with json field
f5e4c6f 
Signed-off-by: Wei Meng <wemeng@microsoft.com>
@m5i-work
Error details
95c4c0e 
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Wwwsylvia
Wwwsylvia approved these changes Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Copy Markdown
Member

FeynmanZhou commented Jun 27, 2022

There are 8 commits in this PR. It is recommended to rebase and squash them into one.

@shizhMSFT
Copy link
Copy Markdown
Contributor

shizhMSFT commented Jun 27, 2022

There are 8 commits in this PR. It is recommended to rebase and squash them into one.

It's okay since oras only allows "squash and merge" so that the main branch is always clean.

shizhMSFT
shizhMSFT approved these changes Jun 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 4728b03 into oras-project:main Jun 27, 2022
@m5i-work m5i-work deleted the v2_api branch June 28, 2022 03:14
@akashsinghal akashsinghal mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Referrers API to match RC.1

5 participants

@m5i-work @Wwwsylvia @northtyphoon @shizhMSFT @FeynmanZhou