Skip to content

Failed to download all the files in an artifact using oras.Copy()#256

Merged
shizhMSFT merged 7 commits into
oras-project:mainfrom
m5i-work:dup
Aug 4, 2022
Merged

Failed to download all the files in an artifact using oras.Copy()#256
shizhMSFT merged 7 commits into
oras-project:mainfrom
m5i-work:dup

Conversation

@m5i-work
Copy link
Copy Markdown
Contributor

@m5i-work m5i-work commented Jul 28, 2022

Resolves #236

Signed-off-by: Wei Meng wemeng@microsoft.com

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #256 (680ecd3) into main (6a09a65) will decrease coverage by 0.08%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   70.57%   70.48%   -0.09%     
==========================================
  Files          35       35              
  Lines        3055     3087      +32     
==========================================
+ Hits         2156     2176      +20     
- Misses        669      678       +9     
- Partials      230      233       +3     
Impacted Files Coverage Δ
content/file/file.go 75.57% <62.50%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@m5i-work
Copy link
Copy Markdown
Contributor Author

@qweeah @Wwwsylvia @shizhMSFT Please take a look when you have time.

@Wwwsylvia
Copy link
Copy Markdown
Member

Wwwsylvia commented Jul 28, 2022

I think you wanted to reference issue #236?

Comment thread copy_test.go
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Copy link
Copy Markdown
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread content/file/file.go Outdated
Comment thread content/file/file.go Outdated
Signed-off-by: Wei Meng <wemeng@microsoft.com>
Comment thread content/file/file.go
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 5115985 into oras-project:main Aug 4, 2022
@m5i-work m5i-work deleted the dup branch August 4, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to download all the files in an artifact using oras.Copy()

5 participants