Skip to content

feat!: Support specifying MaxMetadataBytes option for oras.Resolve and oras.Copy#299

Merged
shizhMSFT merged 4 commits into
oras-project:mainfrom
Wwwsylvia:metadatabytes
Sep 5, 2022
Merged

feat!: Support specifying MaxMetadataBytes option for oras.Resolve and oras.Copy#299
shizhMSFT merged 4 commits into
oras-project:mainfrom
Wwwsylvia:metadatabytes

Conversation

@Wwwsylvia
Copy link
Copy Markdown
Member

@Wwwsylvia Wwwsylvia commented Sep 5, 2022

Resolves #291
Fixes #298
BREAKING CHANGE: Rename oras.TagBytesOptions to oras.TagBytesNOptions

Signed-off-by: Sylvia Lei lixlei@microsoft.com

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia changed the title feat: Support specifying MaxMetadataBytes option for oras.Resolve and oras.Copy feat!: Support specifying MaxMetadataBytes option for oras.Resolve and oras.Copy Sep 5, 2022
@Wwwsylvia Wwwsylvia requested a review from shizhMSFT September 5, 2022 11:22
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit e413b92 into oras-project:main Sep 5, 2022
@Wwwsylvia Wwwsylvia deleted the metadatabytes branch September 6, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Failing to push to the cache of internal.Proxy will result in a deadlock oras.Resolve and oras.Copy should have a MaxMetadataBytes option

2 participants