feat: support deletion for memory graph by wangxiaoxuan273 · Pull Request #606 · oras-project/oras-go

wangxiaoxuan273 · 2023-09-25T05:22:33Z

Signed-off-by: Xiaoxuan Wang wangxiaoxuan119@gmail.com

Part 1/4 of #454

Based on draft PR #582

Current behavior regarding graph.Memory.Remove(node):

node entry in m.successors and m.nodes is removed.
node is removed from its successors predecessors list.
node entry in m.predecessors is NOT removed, unless all its predecessors no longer exist.
node is NOT removed from its predecessors' m.successors list. The m.successors is always in accordance with the actual content.

codecov-commenter · 2023-09-25T07:06:58Z

Codecov Report

❌ Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.11%. Comparing base (e8e4f84) to head (012930a).
⚠️ Report is 122 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/graph/memory.go	96.36%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   74.84%   75.11%   +0.26%     
==========================================
  Files          58       59       +1     
  Lines        5328     5420      +92     
==========================================
+ Hits         3988     4071      +83     
- Misses        987      994       +7     
- Partials      353      355       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Wwwsylvia · 2023-10-09T07:38:58Z

Can we share the benchmark result here? So that the community understands why we merge Memory and DeletableMemory.

wangxiaoxuan273 · 2023-10-09T08:52:36Z

Can we share the benchmark result here? So that the community understands why we merge Memory and DeletableMemory.

Here are the benchmark results of the original graph.Memory implementation (titled Memory, which was optimized for concurrent reads and adds, there was no delete functionality), compared to the current one (titled DeletableMemory, which enables concurrent delete):

for function Index

for function IndexAll

for function Predecessors

The performance is similar, so we use the current implementation.

shizhMSFT

LGTM

shizhMSFT · 2023-10-10T08:10:01Z

The benchmark looks good to me. We can merge this PR once you have addressed @Wwwsylvia 's comments and above minor comments related to the graphs in the test files.

Wwwsylvia

Overall LGTM. Some comments may need rephrasing.

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Wwwsylvia

LGTM

Part 4/4 of #454 This PR should be reviewed and merged after PR #606 #607 #608 --------- Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

wangxiaoxuan273 requested review from SteveLasker, Wwwsylvia, sajayantony and shizhMSFT as code owners September 25, 2023 05:22

Wwwsylvia reviewed Sep 25, 2023

View reviewed changes

Comment thread internal/graph/benchmark_test.go Outdated

Comment thread internal/graph/deletablememory.go Outdated

Comment thread internal/graph/deletablememory_test.go Outdated

wangxiaoxuan273 mentioned this pull request Oct 7, 2023

feat: extend oci.Store with Delete() #614

Merged

Wwwsylvia reviewed Oct 9, 2023

View reviewed changes

Comment thread internal/graph/memory.go

Comment thread internal/graph/memory_test.go Outdated

Comment thread internal/graph/memory_test.go

Comment thread internal/graph/memory_test.go Outdated

Wwwsylvia reviewed Oct 9, 2023

View reviewed changes

Comment thread internal/graph/memory.go

shizhMSFT approved these changes Oct 10, 2023

View reviewed changes

shizhMSFT reviewed Oct 10, 2023

View reviewed changes

Comment thread internal/graph/memory_test.go Outdated

Comment thread internal/graph/memory_test.go Outdated

Wwwsylvia reviewed Oct 13, 2023

View reviewed changes

Comment thread internal/graph/memory.go Outdated

wangxiaoxuan273 added 13 commits October 16, 2023 04:46

feat: support deletion for memory graph

012ab6c

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

added benchmark tests

e1c667f

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

added an ASCII drawing

f98443e

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved comments

6f54047

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

merged deletable memory into memory

08fde14

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved some comments and update the 1st test

b7a10d4

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

cleaned up remove test and updated remove behavior

e32a36c

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

done refining the 1st test

02948ff

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

refined the second test

3f4848d

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

refined doc of Remove

66b1736

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

refined the drawing!

8c0d22a

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

refined the predecessor test

f68a3a3

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

rephrased the doc

012930a

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Wwwsylvia approved these changes Oct 16, 2023

View reviewed changes

Wwwsylvia merged commit 459a246 into oras-project:main Oct 16, 2023

wangxiaoxuan273 deleted the deletable-memory branch October 16, 2023 04:59

Wwwsylvia mentioned this pull request Oct 19, 2023

[RFC] Add Delete() to oci.Store. #620

Closed

shizhMSFT pushed a commit that referenced this pull request Nov 20, 2023

feat: extend oci.Store with Delete() (#614)

75d200e

Part 4/4 of #454 This PR should be reviewed and merged after PR #606 #607 #608 --------- Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Wwwsylvia mentioned this pull request Nov 21, 2023

oci.Store and oci.Storage should implement content.Deleter #454

Closed

Wwwsylvia mentioned this pull request Jan 26, 2024

Vote for release of v2.4.0 #696

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support deletion for memory graph#606

feat: support deletion for memory graph#606
Wwwsylvia merged 13 commits into
oras-project:mainfrom
wangxiaoxuan273:deletable-memory

wangxiaoxuan273 commented Sep 25, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Sep 25, 2023 •

edited by codecov Bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wwwsylvia commented Oct 9, 2023 •

edited

Loading

Uh oh!

wangxiaoxuan273 commented Oct 9, 2023 •

edited

Loading

Uh oh!

shizhMSFT left a comment

Uh oh!

Uh oh!

Uh oh!

shizhMSFT commented Oct 10, 2023

Uh oh!

Wwwsylvia left a comment

Uh oh!

Uh oh!

Wwwsylvia left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wangxiaoxuan273 commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Sep 25, 2023 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wwwsylvia commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wangxiaoxuan273 commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shizhMSFT commented Oct 10, 2023

Uh oh!

Wwwsylvia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Wwwsylvia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wangxiaoxuan273 commented Sep 25, 2023 •

edited

Loading

codecov-commenter commented Sep 25, 2023 •

edited by codecov Bot

Loading

Wwwsylvia commented Oct 9, 2023 •

edited

Loading

wangxiaoxuan273 commented Oct 9, 2023 •

edited

Loading