feat: minimal change to support cross-repo blob mounting#631
Merged
Conversation
ktarplee
requested review from
SteveLasker,
Wwwsylvia,
sajayantony and
shizhMSFT
as code owners
This was referenced Oct 31, 2023
Contributor
|
This is nice. Do we need a test for this? |
Contributor
Author
I just added a test @sajayantony |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 75.12% 75.19% +0.07%
==========================================
Files 59 59
Lines 5427 5427
==========================================
+ Hits 4077 4081 +4
+ Misses 995 992 -3
+ Partials 355 354 -1
|
Wwwsylvia
reviewed
Nov 1, 2023
Member
Wwwsylvia
left a comment
Wwwsylvia
left a comment
There was a problem hiding this comment.
LGTM. Can we have the PR title to start with feat: as per the conventional commits guidance?
ktarplee
changed the title
Also added a test to ensure that pushing the blob is skipped. Signed-off-by: Kyle M. Tarplee <kmtarplee@ieee.org>
Contributor
Author
Sorry about that. I fixed it and the comment in the code. @Wwwsylvia |
Member
|
Thanks @ktarplee . Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export
ErrSkipDescasErrSkipDescallows users of the library to implementCopyGraphOptions.PreCopyto callMount()and then returnErrSkipDescfromPreCopywhich bypasses the downstream copy operation.Closes #580