feat: Public GC function of `oci.Store` by wangxiaoxuan273 · Pull Request #656 · oras-project/oras-go

wangxiaoxuan273 · 2023-12-08T08:47:42Z

Part of #472

codecov-commenter · 2023-12-11T07:46:58Z

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (c34d275) 75.57% compared to head (20af59f) 75.71%.

Files	Patch %	Lines
content/oci/oci.go	77.61%	10 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   75.57%   75.71%   +0.13%     
==========================================
  Files          59       59              
  Lines        5692     5765      +73     
==========================================
+ Hits         4302     4365      +63     
- Misses       1023     1028       +5     
- Partials      367      372       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eiffel-fl

Hi!

This looks really cool!
I tested it and did not find any problem (I am still having blobs not deleted but I am thinking more and more this is because we are doing something wrong on our side).
I just have one comment regarding the TODO but nothing critical.

Best regards.

eiffel-fl

Hi!

I tested it and it works fine! I just found one small nit but unless I am missing something I think we are near the merge.

Best regards.

eiffel-fl

Hi!

I tested it and I like the new approach of using index.json!
I am still getting the same behavior but this is not related to this code (see #664).
I just found one small nit, otherwise, from my side, it is ready to go (note that I am not maintainer here, so just grey checkmark)!

Best regards.

wangxiaoxuan273 · 2024-01-09T10:20:54Z

Current behavior regarding referrers: when a referrer manifest is not in index.json, it will be cleaned by GC. Change may be made in the future when OCI layout has better support for finding referrers.

shizhMSFT

LGTM

Wwwsylvia

LGTM with a few nit suggestions. Please rebase and resolve comments to unblock merge.

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Wwwsylvia

LGTM

wangxiaoxuan273 changed the title ~~Public gc~~ feat: Public GC function of oci.Store Dec 11, 2023

wangxiaoxuan273 marked this pull request as ready for review December 11, 2023 07:17

wangxiaoxuan273 requested review from SteveLasker, Wwwsylvia, sajayantony and shizhMSFT as code owners December 11, 2023 07:17

qweeah reviewed Dec 18, 2023

View reviewed changes

Comment thread content/oci/oci.go

wangxiaoxuan273 marked this pull request as draft December 18, 2023 06:21

eiffel-fl mentioned this pull request Dec 21, 2023

Add ig image remove command inspektor-gadget/inspektor-gadget#2162

Merged

wangxiaoxuan273 marked this pull request as ready for review December 25, 2023 02:15

qweeah reviewed Dec 25, 2023

View reviewed changes

Comment thread internal/graph/memory.go Outdated

Wwwsylvia requested changes Dec 26, 2023

View reviewed changes

shizhMSFT reviewed Dec 28, 2023

View reviewed changes

Comment thread content/oci/oci.go Outdated

Comment thread content/oci/oci.go Outdated

Comment thread content/oci/oci.go

Comment thread content/oci/oci.go

Wwwsylvia reviewed Dec 28, 2023

View reviewed changes

Comment thread internal/graph/memory.go Outdated

Wwwsylvia reviewed Dec 28, 2023

View reviewed changes

Comment thread content/oci/oci.go Outdated

shizhMSFT reviewed Dec 29, 2023

View reviewed changes

Comment thread content/oci/oci.go

shizhMSFT mentioned this pull request Dec 29, 2023

Feature Request: Consider supporting size management for OCI Store #472

Open

Wwwsylvia mentioned this pull request Dec 29, 2023

feat: GC on oci.Store.Delete #653

Merged

eiffel-fl mentioned this pull request Dec 29, 2023

feat: extend oci.Store with DeleteTree(). #645

Closed

eiffel-fl reviewed Dec 29, 2023

View reviewed changes

Comment thread content/oci/oci.go Outdated

eiffel-fl reviewed Jan 3, 2024

View reviewed changes

Comment thread internal/graph/memory.go Outdated

eiffel-fl approved these changes Jan 4, 2024

View reviewed changes

Comment thread content/oci/oci.go Outdated

shizhMSFT reviewed Jan 5, 2024

View reviewed changes

Comment thread content/oci/oci.go Outdated

Comment thread content/oci/oci.go Outdated

Comment thread content/oci/oci.go Outdated

Comment thread content/oci/oci.go

shizhMSFT reviewed Jan 9, 2024

View reviewed changes

Comment thread content/oci/oci.go Outdated

Comment thread content/oci/oci.go

Comment thread content/oci/oci.go Outdated

shizhMSFT approved these changes Jan 10, 2024

View reviewed changes

Wwwsylvia reviewed Jan 10, 2024

View reviewed changes

Comment thread content/oci/oci.go Outdated

Comment thread content/oci/oci.go Outdated

wangxiaoxuan273 added 2 commits January 11, 2024 09:52

feat: dangling node detection for graph.Memory

85a91aa

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved dangling tree issue

07e89df

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

wangxiaoxuan273 added 23 commits January 11, 2024 09:52

removed storage changes

c921137

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved some comments

5083aea

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

added test case for referrers

7b4c0b7

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

replaced walk with loop

a809ea2

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

used traverseIndex

4130046

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

change delete back

b2dd91c

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

added context check

a6adc33

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

revert change in memory

b85b5aa

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

fixed context issue

ca35c14

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

e18dd2f

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

b174f14

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

60624cb

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

bb899fa

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

remove extra set

f896e13

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved comments

eb087c0

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

reload index

2b62edb

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

1e15e73

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

70afd40

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

fc450e1

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

increase coverage

a429bb4

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

minor fix

a6eadac

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved comments

de79a2e

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved comments

20af59f

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Wwwsylvia approved these changes Jan 11, 2024

View reviewed changes

Wwwsylvia merged commit 3b1dd0e into oras-project:main Jan 11, 2024

wangxiaoxuan273 deleted the public-gc branch January 11, 2024 06:07

Wwwsylvia mentioned this pull request Jan 26, 2024

Vote for release of v2.4.0 #696

Closed

4 tasks

Conversation

wangxiaoxuan273 commented Dec 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Dec 11, 2023 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eiffel-fl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eiffel-fl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eiffel-fl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangxiaoxuan273 commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Wwwsylvia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Wwwsylvia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wangxiaoxuan273 commented Dec 8, 2023 •

edited

Loading

codecov-commenter commented Dec 11, 2023 •

edited by codecov Bot

Loading

wangxiaoxuan273 commented Jan 9, 2024 •

edited

Loading