Skip to content

[WIP]Added text to speech instructions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

vachan-maker
Copy link
Contributor

organicmaps/organicmaps#2383

Still working on it.

@vachan-maker vachan-maker changed the title Added text to speech instructions [WIP]Added text to speech instructions Apr 20, 2022
@vachan-maker
Copy link
Contributor Author

Hmm..I forgot to add signed off

@biodranik
Copy link
Member

Thanks! Do you have other devices to take more different screenshots for different Android versions?
@pastk can you help?

@biodranik
Copy link
Member

biodranik commented Apr 20, 2022

It makes sense to provide instructions for different versions of Android, and also some hints on where users can install a proper TTS engine. Some hints can be extracted from existing TTS issues: https://github.com/organicmaps/organicmaps/issues?q=is%3Aissue+tts+

@vachan-maker
Copy link
Contributor Author

No, I don't have any other devices. Yes, I will add the instructions from where users can add a tts engine.

@vachan-maker vachan-maker marked this pull request as draft April 20, 2022 17:41
@pastk
Copy link
Member

pastk commented Apr 21, 2022

Thanks! Do you have other devices to take more different screenshots for different Android versions? @pastk can you help?

I have a custom a9.0 and a5.0 emulator only.

I doubt its reasonable to include screenshots for many versions of vendorized settings layouts. Probably its better to describe (and illustrate with screenshots) a single universal way of using a "Text-to-speech" search to locate the settings.

@vachan-maker
Copy link
Contributor Author

These instructions are from Google

https://support.google.com/accessibility/android/answer/6006983?hl=en

They have only listed one method

@vachan-maker
Copy link
Contributor Author

Added instructions for text to speech on Lineage OS

c) Tap on **text-to-speech output** (below SCREEN READERS)
d) tap on **Preferred engine** (left side) and make sure **eSpeak** is selected

Go to Lineage os main **Settings** --> Scroll down to **Accessibility** --> Select **text-to-speech output** (below SCREEN READERS)--> **Preferred engine** (left side) and make sure **eSpeak** is selected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a markdown, you can make a numbered list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enough?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vachan-maker vachan-maker requested a review from biodranik June 6, 2022 12:33
@vachan-maker vachan-maker marked this pull request as ready for review July 20, 2022 16:29
@rtsisyk rtsisyk self-requested a review September 6, 2022 08:20
Copy link
Member

@rtsisyk rtsisyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtsisyk
Copy link
Member

rtsisyk commented Sep 8, 2022

Hi @vachan-maker , sorry for not getting back to you sooner on this PR. Let's merge it and move forward. I need two things:

  1. Fix zola serve
Error: Reason: Variable `alt` not found in context while rendering 'shortcodes/screenshot.html'
  1. Add Signed-off-by (git commit --amend -s)

https://github.com/organicmaps/organicmaps/blob/master/docs/CONTRIBUTING.md#submitting-your-changes

I promise that we will move forward faster with reviews. This repo just wasn't on my radar.
The further plan is to integrate FAQ from the app (in main repo) and rework the build process to get the generated version from website when building the app.

@vachan-maker
Copy link
Contributor Author

Hi I am really sorry for not completing this.
Is this PR still required? Or should I close it?

@meenbeese
Copy link
Collaborator

Hi I am really sorry for not completing this.
Is this PR still required? Or should I close it?

We appreciate your initial work and are close to finishing it in #171 and #185. Therefore, it makes sense to close this PR in favor of those, where you can review the work and contribute your ideas instead. @vachan-maker

@meenbeese meenbeese closed this Nov 17, 2023
@biodranik biodranik mentioned this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants