-
Notifications
You must be signed in to change notification settings - Fork 42
[WIP]Added text to speech instructions #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm..I forgot to add signed off |
Thanks! Do you have other devices to take more different screenshots for different Android versions? |
It makes sense to provide instructions for different versions of Android, and also some hints on where users can install a proper TTS engine. Some hints can be extracted from existing TTS issues: https://github.com/organicmaps/organicmaps/issues?q=is%3Aissue+tts+ |
Signed-off-by: vachan-maker [email protected]
No, I don't have any other devices. Yes, I will add the instructions from where users can add a tts engine. |
I have a custom a9.0 and a5.0 emulator only. I doubt its reasonable to include screenshots for many versions of vendorized settings layouts. Probably its better to describe (and illustrate with screenshots) a single universal way of using a "Text-to-speech" search to locate the settings. |
These instructions are from Google https://support.google.com/accessibility/android/answer/6006983?hl=en They have only listed one method |
Added instructions for text to speech on Lineage OS |
content/text-to-speech.md
Outdated
c) Tap on **text-to-speech output** (below SCREEN READERS) | ||
d) tap on **Preferred engine** (left side) and make sure **eSpeak** is selected | ||
|
||
Go to Lineage os main **Settings** --> Scroll down to **Accessibility** --> Select **text-to-speech output** (below SCREEN READERS)--> **Preferred engine** (left side) and make sure **eSpeak** is selected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a markdown, you can make a numbered list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's LineageOS
, see https://lineageos.org/ or https://github.com/lineageos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @vachan-maker , sorry for not getting back to you sooner on this PR. Let's merge it and move forward. I need two things:
I promise that we will move forward faster with reviews. This repo just wasn't on my radar. |
Hi I am really sorry for not completing this. |
We appreciate your initial work and are close to finishing it in #171 and #185. Therefore, it makes sense to close this PR in favor of those, where you can review the work and contribute your ideas instead. @vachan-maker |
organicmaps/organicmaps#2383
Still working on it.