Fix BoundError in weights(hook_lengths(...))#4270
Merged
fieker merged 3 commits intooscar-system:masterfrom Nov 6, 2024
JohnAAbbott:master
Merged
Fix BoundError in weights(hook_lengths(...))#4270fieker merged 3 commits intooscar-system:masterfrom JohnAAbbott:master
BoundError in weights(hook_lengths(...))#4270fieker merged 3 commits intooscar-system:masterfrom
JohnAAbbott:master
Conversation
lgoettgens
changed the title
BoundError in weights of YoungDiagram
lgoettgens
changed the title
BoundError in weights of YoungDiagramBoundError in weights(hook_lengths(...))
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4270 +/- ##
==========================================
- Coverage 84.60% 84.48% -0.12%
==========================================
Files 640 641 +1
Lines 85122 85428 +306
==========================================
+ Hits 72014 72171 +157
- Misses 13108 13257 +149
|
Closed
benlorenz
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Added arg check to weights * weight seq of non-semi-standard YT gives error * Inputs for weight seq tests are now semi-standard (cherry picked from commit c40f14e)
lgoettgens
added
the
release notes: use title
lgoettgens
changed the title
BoundError in weights(hook_lengths(...))BoundError in weights(hook_lengths(...))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
weightfunction now checks that its arg is semi-standard, and gives a helpful error if not.The proposed name change discussed in issue #4230 (replace
weightbyweight_sequence) has not been implemented.Resolves #4230.