Speed up stabilizer methods for the natural action of permutation groups, and the actions on sets, tuples, and vectors of pos. integers#4281
Conversation
change the code such that the special GAP methods are used for the natural action of permutation groups, and the actions on sets, tuples, and vectors of pos. integers
|
Here we get a failure in one of the RPTU runs: Perhaps @aaruni96 has an idea what is going on here. |
The relevant error is a few lines above: This looks like some C++ exception handling issue, maybe related to the mixing of different C++ libraries (libstdc++ / libc++). I have seen this a few times but only on the macos RPTU runner. It usually disappears when re-running the job. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4281 +/- ##
=======================================
Coverage 84.49% 84.50%
=======================================
Files 641 641
Lines 85468 85486 +18
=======================================
+ Hits 72218 72236 +18
Misses 13250 13250
|
|
Oh this is great, there are huge speed improvements here. |
mjrodgers
left a comment
There was a problem hiding this comment.
This all looks in order, and we can now do a lot of these calculations much more quickly (and many that were not possible before even).
stabilizer methodsstabilizer methods for the natural action of permutation groups, and the actions on sets, tuples, and vectors of pos. integers
change the code such that the special GAP methods are used for the natural action of permutation groups,
and the actions on sets, tuples, and vectors of pos. integers