Skip to content

Speed up stabilizer methods for the natural action of permutation groups, and the actions on sets, tuples, and vectors of pos. integers#4281

Merged
ThomasBreuer merged 2 commits intooscar-system:masterfrom
ThomasBreuer:TB_stabilizer_special
Nov 7, 2024
Merged

Speed up stabilizer methods for the natural action of permutation groups, and the actions on sets, tuples, and vectors of pos. integers#4281
ThomasBreuer merged 2 commits intooscar-system:masterfrom
ThomasBreuer:TB_stabilizer_special

Conversation

@ThomasBreuer
Copy link
Copy Markdown
Member

change the code such that the special GAP methods are used for the natural action of permutation groups,
and the actions on sets, tuples, and vectors of pos. integers

change the code such that the special GAP methods are used
for the natural action of permutation groups,
and the actions on sets, tuples, and vectors of pos. integers
@ThomasBreuer
Copy link
Copy Markdown
Member Author

Here we get a failure in one of the RPTU runs:

Worker 4 terminated.
Unhandled Task ERROR: EOFError: read end of file

Perhaps @aaruni96 has an idea what is going on here.

@benlorenz
Copy link
Copy Markdown
Member

Here we get a failure in one of the RPTU runs:

Worker 4 terminated.
Unhandled Task ERROR: EOFError: read end of file

Perhaps @aaruni96 has an idea what is going on here.

The relevant error is a few lines above:

      From worker 4:	[58185] signal (11.2): Segmentation fault: 11
      From worker 4:	in expression starting at /Users/aaruni/Desktop/oscar-runners/runner-2/_work/Oscar.jl/Oscar.jl/experimental/BasisLieHighestWeight/test/MainAlgorithm-test.jl:34
      From worker 4:	_ZNK10__cxxabiv120__si_class_type_info12__do_dyncastElNS_17__class_type_info10__sub_kindEPKS1_PKvS4_S6_RNS1_16__dyncast_resultE at /Users/aaruni/Desktop/oscar-runners/runner-2/_work/_tool/julia/1.10.6/aarch64/lib/julia/libstdc++.6.dylib (unknown line)
      From worker 4:	_ZNK10__cxxabiv117__class_type_info9can_catchEPKNS_16__shim_type_infoERPv at /usr/lib/libc++abi.dylib (unknown line)

This looks like some C++ exception handling issue, maybe related to the mixing of different C++ libraries (libstdc++ / libc++). I have seen this a few times but only on the macos RPTU runner. It usually disappears when re-running the job.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (8bea0b6) to head (eb3c763).
Report is 273 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4281   +/-   ##
=======================================
  Coverage   84.49%   84.50%           
=======================================
  Files         641      641           
  Lines       85468    85486   +18     
=======================================
+ Hits        72218    72236   +18     
  Misses      13250    13250           
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 95.01% <100.00%> (+0.01%) ⬆️
src/Groups/action.jl 97.24% <100.00%> (+0.07%) ⬆️
src/Groups/gsets.jl 92.30% <100.00%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

@mjrodgers
Copy link
Copy Markdown
Collaborator

Oh this is great, there are huge speed improvements here.

Copy link
Copy Markdown
Collaborator

@mjrodgers mjrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks in order, and we can now do a lot of these calculations much more quickly (and many that were not possible before even).

@ThomasBreuer ThomasBreuer merged commit 266fc70 into oscar-system:master Nov 7, 2024
@ThomasBreuer ThomasBreuer deleted the TB_stabilizer_special branch November 7, 2024 14:27
@fingolfin fingolfin added enhancement New feature or request optimization Simpler/more performant code or more/better tests labels Feb 27, 2025
@fingolfin fingolfin changed the title improve certain stabilizer methods Speed up stabilizer methods for the natural action of permutation groups, and the actions on sets, tuples, and vectors of pos. integers Feb 27, 2025
@fingolfin fingolfin added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request optimization Simpler/more performant code or more/better tests release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants