Graduate elliptic surfaces from experimental#4294
Merged
simonbrandhorst merged 6 commits intomasterfrom Nov 14, 2024
Merged
Conversation
Collaborator
Author
|
@HechtiDerLachs @afkafkafk13 |
lgoettgens
reviewed
Nov 8, 2024
lgoettgens
reviewed
Nov 8, 2024
lgoettgens
reviewed
Nov 8, 2024
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
lgoettgens
reviewed
Nov 13, 2024
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
HechtiDerLachs
approved these changes
Nov 14, 2024
Collaborator
HechtiDerLachs
left a comment
There was a problem hiding this comment.
Looks good from my side. The splitting of the code makes sense.
Again, I would appreciate it if I was still listed as a co-author of the code after moving to not mess up the statistics too much; but that's a secondary concern.
Collaborator
I will, but after the 22nd. Currently, I'm still busy preparing for Durham (see #4314). |
Collaborator
Author
|
@HechtiDerLachs I added you as a co-author in the squash and merge. I hope it is okay this way (I do not know how to do it otherwise). If not, please feel free to edit the history in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move EllipticSurface and BlowupMorphism to src.
Document EllipticSurface.