Skip to content

Graduate elliptic surfaces from experimental#4294

Merged
simonbrandhorst merged 6 commits intomasterfrom
sb/elliptic_surface
Nov 14, 2024
Merged

Graduate elliptic surfaces from experimental#4294
simonbrandhorst merged 6 commits intomasterfrom
sb/elliptic_surface

Conversation

@simonbrandhorst
Copy link
Copy Markdown
Collaborator

Move EllipticSurface and BlowupMorphism to src.
Document EllipticSurface.

@simonbrandhorst
Copy link
Copy Markdown
Collaborator Author

@HechtiDerLachs @afkafkafk13
I had to move the blowups out of experimental.
Could you please add them to the docu in another PR?

Comment thread docs/doc.main Outdated
Comment thread docs/oscar_references.bib Outdated
Comment thread docs/oscar_references.bib Outdated
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 79.97947% with 390 lines in your changes missing coverage. Please review.

Project coverage is 84.50%. Comparing base (f2329a8) to head (6580c68).
Report is 267 commits behind head on master.

Files with missing lines Patch % Lines
...raicGeometry/Surfaces/EllipticSurface/Morphisms.jl 63.09% 217 Missing ⚠️
...ometry/Surfaces/EllipticSurface/EllipticSurface.jl 83.64% 121 Missing ⚠️
...cGeometry/Surfaces/EllipticSurface/NeighborStep.jl 91.92% 42 Missing ⚠️
...cGeometry/Schemes/CoveredProjectiveScheme/Types.jl 78.37% 8 Missing ⚠️
...Geometry/Surfaces/EllipticSurface/MoveMeToHecke.jl 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4294      +/-   ##
==========================================
+ Coverage   84.48%   84.50%   +0.02%     
==========================================
  Files         641      645       +4     
  Lines       85541    85538       -3     
==========================================
+ Hits        72266    72286      +20     
+ Misses      13275    13252      -23     
Files with missing lines Coverage Δ
...cGeometry/Schemes/BlowupMorphism/BlowupMorphism.jl 84.15% <ø> (ø)
.../AlgebraicGeometry/Schemes/BlowupMorphism/Types.jl 92.59% <ø> (ø)
...CoveredProjectiveScheme/CoveredProjectiveScheme.jl 89.18% <ø> (ø)
...lgebraicGeometry/Surfaces/EllipticSurface/Types.jl 100.00% <100.00%> (ø)
src/deprecations.jl 0.00% <ø> (ø)
...Geometry/Surfaces/EllipticSurface/MoveMeToHecke.jl 94.11% <94.11%> (ø)
...cGeometry/Schemes/CoveredProjectiveScheme/Types.jl 78.37% <78.37%> (ø)
...cGeometry/Surfaces/EllipticSurface/NeighborStep.jl 91.92% <91.92%> (ø)
...ometry/Surfaces/EllipticSurface/EllipticSurface.jl 83.64% <83.64%> (ø)
...raicGeometry/Surfaces/EllipticSurface/Morphisms.jl 63.09% <63.09%> (ø)

... and 8 files with indirect coverage changes

Comment thread docs/oscar_references.bib Outdated
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Copy link
Copy Markdown
Collaborator

@HechtiDerLachs HechtiDerLachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. The splitting of the code makes sense.

Again, I would appreciate it if I was still listed as a co-author of the code after moving to not mess up the statistics too much; but that's a secondary concern.

@HechtiDerLachs
Copy link
Copy Markdown
Collaborator

Could you please add them to the docu in another PR?

I will, but after the 22nd. Currently, I'm still busy preparing for Durham (see #4314).

@simonbrandhorst simonbrandhorst merged commit 499f7ce into master Nov 14, 2024
@simonbrandhorst simonbrandhorst deleted the sb/elliptic_surface branch November 14, 2024 15:54
@simonbrandhorst
Copy link
Copy Markdown
Collaborator Author

@HechtiDerLachs I added you as a co-author in the squash and merge. I hope it is okay this way (I do not know how to do it otherwise). If not, please feel free to edit the history in another PR.

@thofma thofma changed the title Move EllipticSurface to src and document it. EllipticSurface promoted from experimental to Oscar Feb 27, 2025
@thofma thofma changed the title EllipticSurface promoted from experimental to Oscar elliptic surfaces promoted from experimental to Oscar Feb 27, 2025
@thofma thofma added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
@thofma thofma changed the title elliptic surfaces promoted from experimental to Oscar elliptic surfaces promoted from experimental Feb 27, 2025
@fingolfin fingolfin changed the title elliptic surfaces promoted from experimental Promote elliptic surfaces from experimental Feb 27, 2025
@thofma thofma changed the title Promote elliptic surfaces from experimental Graduate elliptic surfaces from experimental Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: highlight release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants