Skip to content

Add is_left and is_right for SubgroupTransversal#4298

Merged
fingolfin merged 2 commits intomasterfrom
mh/groups-left-right
Nov 13, 2024
Merged

Add is_left and is_right for SubgroupTransversal#4298
fingolfin merged 2 commits intomasterfrom
mh/groups-left-right

Conversation

@fingolfin
Copy link
Copy Markdown
Member

Also use is_left/is_right for those and cosets

Also use is_left/is_right for those and cosets
Comment thread src/Groups/cosets.jl Outdated
Comment thread src/Groups/cosets.jl Outdated
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.49%. Comparing base (194d82b) to head (16cc394).
Report is 265 commits behind head on master.

Files with missing lines Patch % Lines
src/Groups/cosets.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4298      +/-   ##
==========================================
- Coverage   84.49%   84.49%   -0.01%     
==========================================
  Files         641      641              
  Lines       85528    85525       -3     
==========================================
- Hits        72269    72264       -5     
- Misses      13259    13261       +2     
Files with missing lines Coverage Δ
src/Groups/cosets.jl 96.02% <90.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

@fingolfin fingolfin enabled auto-merge (squash) November 12, 2024 21:29
Copy link
Copy Markdown
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fingolfin fingolfin merged commit d0984f8 into master Nov 13, 2024
@fingolfin fingolfin deleted the mh/groups-left-right branch November 13, 2024 08:23
@thofma thofma added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
@fingolfin fingolfin changed the title is_left and is_right for SubgroupTransversal Add is_left and is_right for SubgroupTransversal Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants