Fix leading zero bug in matroid_hex#4299
Merged
benlorenz merged 1 commit intooscar-system:masterfrom Nov 12, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4299 +/- ##
==========================================
- Coverage 84.49% 84.49% -0.01%
==========================================
Files 641 641
Lines 85476 85523 +47
==========================================
+ Hits 72226 72264 +38
- Misses 13250 13259 +9
|
Closed
benlorenz
pushed a commit
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit 2d7a2b0)
thofma
added
the
release notes: use title
fingolfin
changed the title
matroid_hex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug that
matroid_hex(uniform_matroid(1,4)) == "r1n4_0f"`.
instead of
matroid_hex(uniform_matroid(1,4)) == "r1n4_f"`.
This does not change the functionality of matroid_hex, but saves memory.