Add action on matrices in row reduced echelon form#4311
Merged
joschmitt merged 3 commits intooscar-system:masterfrom Nov 18, 2024
Merged
Add action on matrices in row reduced echelon form#4311joschmitt merged 3 commits intooscar-system:masterfrom
joschmitt merged 3 commits intooscar-system:masterfrom
Conversation
This implements the action of a matrix group on subspaces of its natural module.
thofma
reviewed
Nov 14, 2024
| ``` | ||
| """ | ||
| function on_rref_mats(m::MatElem{T}, x::MatrixGroupElem) where T <: FinFieldElem | ||
| return rref(m * x)[2] |
Collaborator
There was a problem hiding this comment.
Suggested change
| return rref(m * x)[2] | |
| return echelon_form(m * x) |
Collaborator
There was a problem hiding this comment.
It is the same, but since we have echelon_form, we might as well make use of it.
Call `echelon_form` instead of `rref`, rename the function accordingly. (Also `echelon_form` cannot be referenced via `@ref`.)
(`rref` and `echelon_form` have different output ...)
mjrodgers
approved these changes
Nov 18, 2024
Collaborator
mjrodgers
left a comment
mjrodgers
left a comment
There was a problem hiding this comment.
This looks good. It seems to be a good starting point for what I need, thanks Thomas..
lgoettgens
added
the
release notes: use title
lgoettgens
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the action of a matrix group on subspaces of its natural module.