Skip to content

Add demazure_character#4339

Merged
lgoettgens merged 12 commits intooscar-system:masterfrom
janikapeters:jp/demazure-character
Nov 27, 2024
Merged

Add demazure_character#4339
lgoettgens merged 12 commits intooscar-system:masterfrom
janikapeters:jp/demazure-character

Conversation

@janikapeters
Copy link
Copy Markdown
Collaborator

@janikapeters janikapeters commented Nov 21, 2024

Implemented by the request of @lgoettgens and @gfourier
I am still writing documentation and tests

@lgoettgens lgoettgens added topic: lie theory experimental Only changes experimental parts of the code labels Nov 21, 2024
@lgoettgens
Copy link
Copy Markdown
Member

Just for future reference: @janikapeters is a student assistant at RWTH Aachen under the supervision of @gfourier and me working on project A24, in particular in extending the BasisLieHighestWeight experimental project to work for Demazure modules.

Comment thread experimental/LieAlgebras/src/RootSystem.jl Outdated
Comment thread experimental/LieAlgebras/src/RootSystem.jl Outdated
Comment thread experimental/LieAlgebras/src/RootSystem.jl Outdated
Comment thread experimental/LieAlgebras/src/RootSystem.jl Outdated
Comment thread experimental/LieAlgebras/src/RootSystem.jl Outdated
Comment thread experimental/LieAlgebras/src/RootSystem.jl
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (4d753d8) to head (a326c1b).
Report is 222 commits behind head on master.

Files with missing lines Patch % Lines
experimental/LieAlgebras/src/RootSystem.jl 96.72% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4339      +/-   ##
==========================================
+ Coverage   84.31%   84.32%   +0.01%     
==========================================
  Files         649      649              
  Lines       86345    86430      +85     
==========================================
+ Hits        72799    72882      +83     
- Misses      13546    13548       +2     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/LieAlgebraModule.jl 88.83% <100.00%> (+0.32%) ⬆️
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/src/RootSystem.jl 93.73% <96.72%> (+0.25%) ⬆️

Comment thread experimental/LieAlgebras/test/LieAlgebraModule-test.jl Outdated
Comment thread experimental/LieAlgebras/test/LieAlgebraModule-test.jl Outdated
Comment thread experimental/LieAlgebras/test/LieAlgebraModule-test.jl Outdated
Comment thread experimental/LieAlgebras/test/LieAlgebraModule-test.jl Outdated
Comment thread experimental/LieAlgebras/test/LieAlgebraModule-test.jl
@lgoettgens
Copy link
Copy Markdown
Member

just as a small heads-up: #4344 is very probably creating some conflicts with this PR here. I can try to help you with that when you drop by my office later today

@janikapeters janikapeters marked this pull request as ready for review November 26, 2024 17:51
Copy link
Copy Markdown
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lgoettgens lgoettgens enabled auto-merge (squash) November 26, 2024 17:55
@lgoettgens lgoettgens disabled auto-merge November 26, 2024 18:02
@lgoettgens lgoettgens merged commit 9da6d04 into oscar-system:master Nov 27, 2024
@micjoswig
Copy link
Copy Markdown
Member

micjoswig commented Dec 1, 2024

Your new code for demazure_character is somehow in conflict (or overlaps) with a polyhedral construction in

demazure_character(lambda::AbstractVector, sigma::PermGroupElem)

This requires a clean up.

While the polyhedral construction was maybe ad hoc, and yours is more general, the interface for the polyhedral one has been fixed for v1.0.

@tbrysiewicz @fingolfin

@janikapeters janikapeters deleted the jp/demazure-character branch December 5, 2024 09:47
@lgoettgens lgoettgens added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
@lgoettgens lgoettgens changed the title LieAlgebras: Add Demazure character Add demazure_character Feb 27, 2025
@lgoettgens lgoettgens mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental Only changes experimental parts of the code release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: lie theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants