Improve isomorphism from pc-groups and fp-groups to FinGenAbGroup#4357
Merged
fingolfin merged 3 commits intooscar-system:masterfrom Nov 29, 2024
Merged
Improve isomorphism from pc-groups and fp-groups to FinGenAbGroup#4357fingolfin merged 3 commits intooscar-system:masterfrom
isomorphism from pc-groups and fp-groups to FinGenAbGroup#4357fingolfin merged 3 commits intooscar-system:masterfrom
Conversation
- introduce `_exponent_vector` for elements in pc and fp groups,
(perhaps to be renamed), use it in `map_word`
- introduce `exponents_of_abelianization` (perhaps to be documented)
- add a special `isomorphism(::Type{PcGroup}, A::FinGenAbGroup)` method
that avoids multiplications in the functions for mapping elements
- replace the special `isomorphism(::Type{FPGroup}, A::FinGenAbGroup)`
method by one that avoids multiplications in the functions for mapping
elements
- change `(G::FPGroup)(pairs::AbstractVector{Pair{T, S}})` to call the
relevant GAP functions directly
fingolfin
reviewed
Nov 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4357 +/- ##
==========================================
- Coverage 84.50% 84.31% -0.20%
==========================================
Files 645 651 +6
Lines 85621 86543 +922
==========================================
+ Hits 72354 72965 +611
- Misses 13267 13578 +311
|
fingolfin
changed the title
isomorphism methods to FinGenAbGroupsisomorphism from pc-groups and fp-groups to FinGenAbGroup
fingolfin
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4323
introduce
_exponent_vectorfor elements in pc and fp groups, (perhaps to be renamed), use it inmap_wordintroduce
exponents_of_abelianization(perhaps to be documented)add a special
isomorphism(::Type{PcGroup}, A::FinGenAbGroup)method that avoids multiplications in the functions for mapping elementsreplace the special
isomorphism(::Type{FPGroup}, A::FinGenAbGroup)method by one that avoids multiplications in the functions for mapping elementschange
(G::FPGroup)(pairs::AbstractVector{Pair{T, S}})to call the relevant GAP functions directlychange
syllablesto return a vector of pairs where the second entry isZZRingElemnotInt, since the exponents can be arbitrarily large