Conversation
lgoettgens
reviewed
Nov 27, 2024
8ebe752 to
a43c495
Compare
fingolfin
commented
Nov 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4361 +/- ##
=======================================
Coverage 84.37% 84.37%
=======================================
Files 656 656
Lines 87190 87202 +12
=======================================
+ Hits 73563 73575 +12
Misses 13627 13627
|
Member
|
Triage likes the idea that |
Member
|
Currently the documentation of |
Also adjust the docstring. Point out that omitting the parent group is
not advisable, and change uses of cperm in tests to provide a parent.
Before:
julia> g = symmetric_group(15);
julia> @Btime cperm($g, 1:4,5:6,7:15);
5.007 μs (69 allocations: 3.05 KiB)
After:
julia> g = symmetric_group(15);
julia> @Btime cperm($g, 1:4,5:6,7:15);
1.238 μs (6 allocations: 416 bytes)
Member
Author
|
I have now updated this to restore support for non-disjoint cycles. |
ThomasBreuer
approved these changes
Dec 4, 2024
Member
ThomasBreuer
left a comment
There was a problem hiding this comment.
Looks good, thanks.
(A local variable gens is used in the tests, but this can be improved in another pull request.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adjust the docstring. Point out that omitting the parent group is not advisable, and change uses of cperm in tests to provide a parent.
Before:
After:
There is actually some more space for improvement by adding some low level primitives for accessing and creating GAP permutations, but that's for a future PR. In the meantime this already improves things and I don't want to rebase this once again.
This was created as part of work with @Pascalonyy on Origamis from 1 year ago, for AG Weitze-Schmithüsen in Saarbrücken. Sadly that never went anywhere as far as I know, but I can at least salvage some of the bits I provided to make things much faster there.