Fix wrong result of isomorphism(FPGroup, G, on_gens = true) for trivial G with more than 0 generators#4378
Merged
fingolfin merged 2 commits intooscar-system:masterfrom Dec 3, 2024
Conversation
for trivial `G` with more than 0 generators
fieker
approved these changes
Dec 3, 2024
Contributor
fieker
left a comment
fieker
left a comment
There was a problem hiding this comment.
if it helps... I am never sure about the gap side, in particular in view of the TODO
lgoettgens
reviewed
Dec 3, 2024
| if is_trivial(G) && ngens(G) == 0 | ||
| # TODO: remove this special treatment as soon as the change from | ||
| # https://github.com/gap-system/gap/pull/5700 is available in Oscar | ||
| # (not yet in GAP 4.13.0) |
Member
There was a problem hiding this comment.
gap-system/gap#5700 was backported to gap 4.13.1 which is available in Oscar right now, so you could remove this special case altogether if I am not mistaken here
Member
There was a problem hiding this comment.
Indeed, that seems to work. I just pushed a corresponding commit. It works locally, let's see if it also passes CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4378 +/- ##
==========================================
- Coverage 84.36% 84.36% -0.01%
==========================================
Files 652 652
Lines 86955 86952 -3
==========================================
- Hits 73360 73356 -4
- Misses 13595 13596 +1
|
fingolfin
changed the title
isomorphism(FPGroup, G, on_gens = true)isomorphism(FPGroup, G, on_gens = true) for trivial G with more than 0 generators
fingolfin
added
bug
fingolfin
changed the title
isomorphism(FPGroup, G, on_gens = true) for trivial G with more than 0 generatorsisomorphism(FPGroup, G, on_gens = true) for trivial G with more than 0 generators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for trivial
Gwith more than 0 generatorsresolves #4377