Skip to content

Allow checking containment of points in hyperplanes and halfspaces via in#4392

Merged
lkastner merged 3 commits intomasterfrom
lk/containment_checks
Jan 3, 2025
Merged

Allow checking containment of points in hyperplanes and halfspaces via in#4392
lkastner merged 3 commits intomasterfrom
lk/containment_checks

Conversation

@lkastner
Copy link
Copy Markdown
Member

@lkastner lkastner commented Dec 11, 2024

julia> c = cube(2,0,1)
Polytope in ambient dimension 2

julia> Fchyp = facets(Hyperplane, c)
4-element SubObjectIterator{AffineHyperplane{QQFieldElem}} over the hyperplanes of R^2 described by:
-x_1 = 0
x_1 = 1
-x_2 = 0
x_2 = 1


julia> Fchalf = facets(c)
4-element SubObjectIterator{AffineHalfspace{QQFieldElem}} over the halfspaces of R^2 described by:
-x_1 <= 0
x_1 <= 1
-x_2 <= 0
x_2 <= 1


julia> for f in Fchyp
       println([0,0] in f)
       end
true
false
true
false

julia> for f in Fchalf
       println([0,0] in f)
       end
true
true
true
true

@lkastner lkastner added enhancement New feature or request topic: polyhedral geometry Issue concerns polyhedral geometry code labels Dec 11, 2024
@lkastner lkastner force-pushed the lk/containment_checks branch from b069de7 to 4c48365 Compare December 11, 2024 13:39
@lkastner lkastner requested a review from benlorenz December 11, 2024 13:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (d1d6926) to head (f358d35).
Report is 173 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4392      +/-   ##
==========================================
- Coverage   84.39%   84.30%   -0.09%     
==========================================
  Files         659      663       +4     
  Lines       87183    87792     +609     
==========================================
+ Hits        73575    74013     +438     
- Misses      13608    13779     +171     
Files with missing lines Coverage Δ
src/PolyhedralGeometry/Cone/properties.jl 90.47% <100.00%> (+0.23%) ⬆️
src/PolyhedralGeometry/Polyhedron/properties.jl 86.64% <100.00%> (+0.14%) ⬆️
src/PolyhedralGeometry/iterators.jl 92.26% <100.00%> (+0.13%) ⬆️

... and 5 files with indirect coverage changes

@lkastner lkastner force-pushed the lk/containment_checks branch from 4c48365 to 4383bf8 Compare December 11, 2024 21:52
Comment thread src/PolyhedralGeometry/Cone/properties.jl
@lkastner lkastner force-pushed the lk/containment_checks branch from c5cd8f6 to 7b32ade Compare January 2, 2025 10:26
@lkastner lkastner merged commit e5a71df into master Jan 3, 2025
@lkastner lkastner deleted the lk/containment_checks branch January 3, 2025 23:15
@fingolfin fingolfin changed the title [PolyhedralGeometry] Check containment of points in hyperplanes and halfspaces Allow checking containment of points in hyperplanes and halfspaces via in Feb 27, 2025
@fingolfin fingolfin added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: polyhedral geometry Issue concerns polyhedral geometry code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants