Add isomorphic_subgroups#4401
Merged
fingolfin merged 1 commit intooscar-system:masterfrom Dec 13, 2024
Merged
Conversation
and add missing `is_isomorphic` method for `FinGenAbGroup`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4401 +/- ##
=======================================
Coverage 84.40% 84.40%
=======================================
Files 656 656
Lines 87246 87270 +24
=======================================
+ Hits 73640 73661 +21
- Misses 13606 13609 +3
|
mjrodgers
approved these changes
Dec 13, 2024
Collaborator
mjrodgers
left a comment
mjrodgers
left a comment
There was a problem hiding this comment.
This looks good! I'm assuming these two checks that fail are just flukes and will pass on another run.
Member
|
The book test nightly failure is #4402. I restarted the julia 1.6 job. |
fingolfin
approved these changes
Dec 13, 2024
fingolfin
added
release notes: use title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and add missing
is_isomorphicmethod forFinGenAbGroup