Skip to content

Support character_field for a vector of characters#4411

Merged
fingolfin merged 1 commit intooscar-system:masterfrom
ThomasBreuer:TB_common_character_field
Jan 6, 2025
Merged

Support character_field for a vector of characters#4411
fingolfin merged 1 commit intooscar-system:masterfrom
ThomasBreuer:TB_common_character_field

Conversation

@ThomasBreuer
Copy link
Copy Markdown
Member

@ThomasBreuer ThomasBreuer commented Dec 20, 2024

This feature turned out to be useful in the computations with S-characters.

@ThomasBreuer ThomasBreuer added enhancement New feature or request topic: groups labels Dec 20, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (57c1b68) to head (8392dcd).
Report is 175 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4411      +/-   ##
==========================================
- Coverage   84.38%   84.38%   -0.01%     
==========================================
  Files         658      658              
  Lines       87162    87173      +11     
==========================================
+ Hits        73555    73564       +9     
- Misses      13607    13609       +2     
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 95.16% <100.00%> (+0.01%) ⬆️
src/Groups/group_characters.jl 95.73% <100.00%> (+0.08%) ⬆️

... and 7 files with indirect coverage changes

@ThomasBreuer ThomasBreuer requested a review from fingolfin January 2, 2025 09:44
@fingolfin fingolfin merged commit ca6a3c3 into oscar-system:master Jan 6, 2025
@ThomasBreuer ThomasBreuer deleted the TB_common_character_field branch January 6, 2025 12:33
@fingolfin fingolfin added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
@fingolfin fingolfin changed the title support character_field for a vector of characters Support character_field for a vector of characters Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants