Fix is_irreducible for number field order elements#4424
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4424 +/- ##
==========================================
+ Coverage 84.34% 84.36% +0.02%
==========================================
Files 663 663
Lines 87788 87788
==========================================
+ Hits 74042 74060 +18
+ Misses 13746 13728 -18
|
fieker
approved these changes
Jan 8, 2025
Contributor
fieker
left a comment
fieker
left a comment
There was a problem hiding this comment.
I wonder how many solve/ kernel right left problems we're still having?
aaruni96
added
the
release notes: use title
fingolfin
changed the title
is_irreducible for number field order elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.