Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4429 +/- ##
==========================================
+ Coverage 84.34% 84.36% +0.02%
==========================================
Files 663 663
Lines 87788 87805 +17
==========================================
+ Hits 74042 74076 +34
+ Misses 13746 13729 -17
|
fieker
approved these changes
Jan 8, 2025
Contributor
fieker
left a comment
There was a problem hiding this comment.
If it works... This is the correct idea...
Using ring confirmance will be fun as boundrings are no rings....
R() when R is a BoundedRing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
The Galois group code uses univariate evaluation, which we want to change in Nemocas/AbstractAlgebra.jl#1948 to use inplace operation like
addmul!, which will callR().