Skip to content

Rename new_ray to exceptional_ray#4433

Merged
HereAround merged 2 commits intooscar-system:masterfrom
paemurru:ep/rename_exceptional_ray
Jan 9, 2025
Merged

Rename new_ray to exceptional_ray#4433
HereAround merged 2 commits intooscar-system:masterfrom
paemurru:ep/rename_exceptional_ray

Conversation

@paemurru
Copy link
Copy Markdown
Collaborator

@paemurru paemurru commented Jan 9, 2025

When blowing up along a ray, the ray might coincide with an existing ray, so the variable name new_ray, as well as the corresponding function names, are unsuitable.

Blowing up along a ray, the ray might coincide with an existing ray, so the variable name `new_ray` and corresponding function names are unsuitable.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (8ab4265) to head (a97a673).
Report is 156 commits behind head on master.

Files with missing lines Patch % Lines
experimental/FTheoryTools/src/auxiliary.jl 50.00% 1 Missing ⚠️
...erimental/Schemes/src/ToricBlowups/constructors.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4433      +/-   ##
==========================================
- Coverage   84.39%   84.39%   -0.01%     
==========================================
  Files         663      663              
  Lines       87954    87939      -15     
==========================================
- Hits        74227    74212      -15     
  Misses      13727    13727              
Files with missing lines Coverage Δ
...xperimental/Schemes/src/ToricBlowups/attributes.jl 93.54% <100.00%> (ø)
experimental/Schemes/src/ToricBlowups/methods.jl 95.83% <100.00%> (ø)
experimental/Schemes/src/ToricBlowups/types.jl 72.72% <100.00%> (+0.41%) ⬆️
...alGeometry/PolyhedralFan/standard_constructions.jl 100.00% <100.00%> (ø)
experimental/FTheoryTools/src/auxiliary.jl 76.00% <50.00%> (ø)
...erimental/Schemes/src/ToricBlowups/constructors.jl 89.83% <92.85%> (ø)

... and 2 files with indirect coverage changes

Copy link
Copy Markdown
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good renaming. Thank you for working on this @paemurru !

@HereAround HereAround merged commit 3505630 into oscar-system:master Jan 9, 2025
@paemurru paemurru deleted the ep/rename_exceptional_ray branch January 9, 2025 22:17
@aaruni96 aaruni96 added renaming release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Jan 30, 2025
@fingolfin fingolfin changed the title Rename new_ray to exceptional_ray Rename new_ray to exceptional_ray Feb 27, 2025
@fingolfin
Copy link
Copy Markdown
Member

@paemurru @HereAround I added the "topic: toric varieties" label. Please change this if you feel some other "topic" label is more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes renaming topic: toric geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants