Rename new_ray to exceptional_ray#4433
Merged
HereAround merged 2 commits intooscar-system:masterfrom Jan 9, 2025
Merged
Conversation
Blowing up along a ray, the ray might coincide with an existing ray, so the variable name `new_ray` and corresponding function names are unsuitable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4433 +/- ##
==========================================
- Coverage 84.39% 84.39% -0.01%
==========================================
Files 663 663
Lines 87954 87939 -15
==========================================
- Hits 74227 74212 -15
Misses 13727 13727
|
HereAround
approved these changes
Jan 9, 2025
Member
HereAround
left a comment
There was a problem hiding this comment.
Looks like a good renaming. Thank you for working on this @paemurru !
new_ray to exceptional_ray
Member
|
@paemurru @HereAround I added the "topic: toric varieties" label. Please change this if you feel some other "topic" label is more appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When blowing up along a ray, the ray might coincide with an existing ray, so the variable name
new_ray, as well as the corresponding function names, are unsuitable.