Add support for all vertical, well-quantized G4s that do not break the non-abelian gauge group#4446
Conversation
lgoettgens
left a comment
There was a problem hiding this comment.
Some random comments with small improvements to allocation reduction and type stability. There are many very similar opportunities to be improved that should be tackled at some point
d24abb5 to
7255b9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4446 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.02%
==========================================
Files 668 668
Lines 88363 88598 +235
==========================================
+ Hits 74600 74788 +188
- Misses 13763 13810 +47
|
d2c7128 to
4914e16
Compare
Thank you. I have taken your points into account. Ideally, 4914e16 should improve the code efficiency. But I am certain that there is a LOT more that could be done - in a separate PR. |
|
With that being said @apturner and @emikelsons , this PR should be ready for review. |
…do not break the non-Abelian gauge group
4914e16 to
ea75840
Compare
|
|
ea75840 to
75a0598
Compare
Co-authored-by: Miķelis Emīls Miķelsons <mikelis.emils.mikelsons@gmail.com>
f55af64 to
ad82faf
Compare
|
@emikelsons Thank you for spotting all those mistakes. Great catches! I just tried to fix those. Let us see if the tests succeed. |
cc @apturner @emikelsons