Generalize monomials_of_degree to allow graded rings with grading group Z#4456
Merged
joschmitt merged 2 commits intooscar-system:masterfrom Jan 14, 2025
Merged
Conversation
Now allows graded rings with grading group Z, provided we select only variables of degree 1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4456 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.01%
==========================================
Files 668 668
Lines 88363 88442 +79
==========================================
+ Hits 74600 74658 +58
- Misses 13763 13784 +21
|
joschmitt
reviewed
Jan 13, 2025
lgoettgens
reviewed
Jan 13, 2025
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
joschmitt
approved these changes
Jan 13, 2025
aaruni96
added
the
release notes: to be added
fingolfin
changed the title
monomials_of_degree to allow graded rings with grading group Z
fingolfin
added
topic: commutative algebra
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now allows graded rings with grading group Z, provided we select only variables of degree 1.