Skip to content

Add weights method for graded rings and improve some documentation#4458

Merged
wdecker merged 4 commits intomasterfrom
Wolfram
Jan 14, 2025
Merged

Add weights method for graded rings and improve some documentation#4458
wdecker merged 4 commits intomasterfrom
Wolfram

Conversation

@wdecker
Copy link
Copy Markdown
Collaborator

@wdecker wdecker commented Jan 13, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (1b9a50d) to head (b39919d).
Report is 145 commits behind head on master.

Files with missing lines Patch % Lines
src/Rings/mpoly-graded.jl 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4458      +/-   ##
==========================================
- Coverage   84.41%   84.39%   -0.02%     
==========================================
  Files         668      668              
  Lines       88439    88606     +167     
==========================================
+ Hits        74656    74782     +126     
- Misses      13783    13824      +41     
Files with missing lines Coverage Δ
src/Rings/mpoly-ideals.jl 94.14% <100.00%> (ø)
src/Rings/mpoly-graded.jl 90.25% <25.00%> (-1.23%) ⬇️

... and 10 files with indirect coverage changes

Comment thread src/Rings/mpoly-ideals.jl Outdated
Do not undo the caching of radicals.
@HechtiDerLachs HechtiDerLachs enabled auto-merge (squash) January 14, 2025 14:35
@wdecker wdecker closed this Jan 14, 2025
auto-merge was automatically disabled January 14, 2025 15:37

Pull request was closed

@wdecker wdecker reopened this Jan 14, 2025
@wdecker wdecker enabled auto-merge (squash) January 14, 2025 15:53
@wdecker wdecker merged commit 263dadd into master Jan 14, 2025
@wdecker wdecker deleted the Wolfram branch January 14, 2025 18:33
@aaruni96 aaruni96 added documentation Improvements or additions to documentation release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jan 30, 2025
@fingolfin fingolfin changed the title some tweaks in docu, add method weights for graded rings Add weights method for graded rings Feb 27, 2025
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 27, 2025
@fingolfin fingolfin changed the title Add weights method for graded rings Add weights method for graded rings and improve some documentation Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants