Clean up some code that got obsolete by newer GAP#4464
Clean up some code that got obsolete by newer GAP#4464lgoettgens merged 4 commits intooscar-system:masterfrom
Conversation
| GAP := ">= 4.12", | ||
| GAP := ">= 4.14", | ||
| NeededOtherPackages := [ | ||
| ["JuliaInterface", ">=0.9"], |
| S = sylow_subgroup(GL, 2)[1] | ||
| for G in [GL, S] | ||
| # for k in 0:n # k = 0 is a problem in GAP 4.12.0 | ||
| # for k in 0:n # k = 0 is a problem in GAP 4.14.0 |
There was a problem hiding this comment.
Meanwhile I think it is better to fix this on the Oscar side. I will create a pull request for that.
lgoettgens
force-pushed
the
lg/GAP-cleanup
branch
from
25a9b6d to
07e8035
Compare
| H = T(GAPWrap.ImagesSource(f)) | ||
| # TODO: remove the next line once GAP 4.13.0 is available in Oscar | ||
| # TODO: remove the next line once GAP 4.13.0 is available in Oscar -> still broken in GAP 4.14.0 | ||
| GAP.Globals.UseIsomorphismRelation(GapObj(G), GapObj(H)) |
There was a problem hiding this comment.
at least for the case of PermGroups. After I remove this line as indicated in the comment:
julia> G = dihedral_group(6)
Pc group of order 6
julia> iso = isomorphism(PermGroup, G)
Group homomorphism
from pc group of order 6
to permutation group of degree 3 and order 6
julia> has_order(codomain(iso))
falseWith the line still in, the last result is true instead.
This got caught by the doctest
Oscar.jl/src/Groups/homomorphisms.jl
Line 598 in 07e8035
There was a problem hiding this comment.
When checking whether GAP now calls UseIsomorphismRelation, I tried a bigger group, and there is an early exit for very small groups.
The GAP code in question has several return statements, I have to think about a good solution.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4464 +/- ##
==========================================
- Coverage 84.41% 84.39% -0.02%
==========================================
Files 668 668
Lines 88591 88603 +12
==========================================
- Hits 74780 74779 -1
- Misses 13811 13824 +13
|
aaruni96
added
the
release notes: not needed
4 participants
No description provided.