Skip to content

Add dedicated stabilizer methods for matrix groups for improved performance#4469

Merged
fingolfin merged 1 commit intooscar-system:masterfrom
ThomasBreuer:TB_stab_matgroup
Jan 16, 2025
Merged

Add dedicated stabilizer methods for matrix groups for improved performance#4469
fingolfin merged 1 commit intooscar-system:masterfrom
ThomasBreuer:TB_stab_matgroup

Conversation

@ThomasBreuer
Copy link
Copy Markdown
Member

The idea is to call GAPWrap.Stabilizer with GAP objects and a GAP action function where this is possible.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (263dadd) to head (4ea1364).
Report is 136 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4469      +/-   ##
==========================================
- Coverage   84.40%   84.39%   -0.01%     
==========================================
  Files         668      668              
  Lines       88606    88587      -19     
==========================================
- Hits        74784    74766      -18     
+ Misses      13822    13821       -1     
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 95.19% <100.00%> (+0.01%) ⬆️
src/Groups/action.jl 97.90% <100.00%> (+0.44%) ⬆️
src/Groups/gsets.jl 92.47% <100.00%> (-0.12%) ⬇️

... and 13 files with indirect coverage changes

@fingolfin fingolfin merged commit 0de68cf into oscar-system:master Jan 16, 2025
@fingolfin fingolfin added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Jan 16, 2025
@fingolfin fingolfin changed the title add special stabilizer methods for matrix groups Add dedicated stabilizer methods for matrix groups for improved performance Jan 16, 2025
@ThomasBreuer ThomasBreuer deleted the TB_stab_matgroup branch January 22, 2025 14:41
@fingolfin fingolfin added optimization Simpler/more performant code or more/better tests release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimization Simpler/more performant code or more/better tests release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants