Add integer_hull and gomory_chvatal_closure#4482
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4482 +/- ##
==========================================
+ Coverage 84.37% 84.55% +0.17%
==========================================
Files 672 672
Lines 88719 88879 +160
==========================================
+ Hits 74858 75149 +291
+ Misses 13861 13730 -131
|
benlorenz
reviewed
Jan 20, 2025
Member
benlorenz
left a comment
benlorenz
left a comment
There was a problem hiding this comment.
Looks good, I added two small suggestions and please add the functions to one of the .md files for the html documentation.
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
lgoettgens
added
the
topic: polyhedral geometry
benlorenz
approved these changes
Jan 22, 2025
aaruni96
added
the
release notes: to be added
fingolfin
changed the title
integer_hull and gomory_chvatal_closure
fingolfin
added
release notes: use title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was at a conference on optimization last week, showing OSCAR around. I realized that we can bring a few additional functions from polymake which are useful for these people.